Re: [Qemu-devel] [RFC PATCH v2 5/7] kbd-state: use state tracker for vnc

2019-01-22 Thread Daniel P . Berrangé
On Tue, Jan 22, 2019 at 10:00:36AM +0100, Gerd Hoffmann wrote: > > > @@ -1859,30 +1828,25 @@ static void do_key_event(VncState *vs, int down, > > > int keycode, int sym) > > > toggles capslock away from the VNC window. > > > */ > > > int uppercase = !!(sym >= 'A' && s

Re: [Qemu-devel] [RFC PATCH v2 5/7] kbd-state: use state tracker for vnc

2019-01-22 Thread Gerd Hoffmann
> > @@ -1859,30 +1828,25 @@ static void do_key_event(VncState *vs, int down, > > int keycode, int sym) > > toggles capslock away from the VNC window. > > */ > > int uppercase = !!(sym >= 'A' && sym <= 'Z'); > > -int shift = !!(vs->modifiers_state[0x2a] | > >

Re: [Qemu-devel] [RFC PATCH v2 5/7] kbd-state: use state tracker for vnc

2018-12-21 Thread Daniel P . Berrangé
On Wed, Dec 19, 2018 at 01:09:02PM +0100, Gerd Hoffmann wrote: > Use the new keyboard state tracked for vnc. Allows to drop the > vnc-specific modifier state tracking code. > > Signed-off-by: Gerd Hoffmann > --- > ui/vnc.h | 5 ++- > ui/vnc.c | 120 > ++---

[Qemu-devel] [RFC PATCH v2 5/7] kbd-state: use state tracker for vnc

2018-12-19 Thread Gerd Hoffmann
Use the new keyboard state tracked for vnc. Allows to drop the vnc-specific modifier state tracking code. Signed-off-by: Gerd Hoffmann --- ui/vnc.h | 5 ++- ui/vnc.c | 120 ++- 2 files changed, 35 insertions(+), 90 deletions(-) diff