Re: [Qemu-devel] [RFC PATCH v2 6/6] hw: arm_gic_kvm: Add KVM VGIC save/restore logic

2013-11-18 Thread Christoffer Dall
On Tue, Oct 15, 2013 at 12:15:03PM +0100, Peter Maydell wrote: > On 26 September 2013 22:03, Christoffer Dall > wrote: > > Save and restore the ARM KVM VGIC state from the kernel. We rely on > > QEMU to marshal the GICState data structure and therefore simply > > synchronize the kernel state with

Re: [Qemu-devel] [RFC PATCH v2 6/6] hw: arm_gic_kvm: Add KVM VGIC save/restore logic

2013-11-18 Thread Christoffer Dall
On Fri, Sep 27, 2013 at 09:11:18AM +0100, Alex Bennée wrote: > > christoffer.d...@linaro.org writes: > [...] > > + > > +static void translate_active(GICState *s, int irq, int cpu, > > + uint32_t *field, bool to_kernel) > > +{ > > +int cm = (irq < GIC_INTERNAL) ?

Re: [Qemu-devel] [RFC PATCH v2 6/6] hw: arm_gic_kvm: Add KVM VGIC save/restore logic

2013-10-15 Thread Peter Maydell
On 26 September 2013 22:03, Christoffer Dall wrote: > Save and restore the ARM KVM VGIC state from the kernel. We rely on > QEMU to marshal the GICState data structure and therefore simply > synchronize the kernel state with the QEMU emulated state in both > directions. > > We take some care on t

Re: [Qemu-devel] [RFC PATCH v2 6/6] hw: arm_gic_kvm: Add KVM VGIC save/restore logic

2013-10-15 Thread Peter Maydell
On 27 September 2013 09:11, Alex Bennée wrote: > > christoffer.d...@linaro.org writes: > >> Save and restore the ARM KVM VGIC state from the kernel. We rely on > >> >> static const VMStateDescription vmstate_gic = { >> .name = "arm_gic", >> -.version_id = 6, >> -.minimum_version_id

Re: [Qemu-devel] [RFC PATCH v2 6/6] hw: arm_gic_kvm: Add KVM VGIC save/restore logic

2013-09-27 Thread Alex Bennée
christoffer.d...@linaro.org writes: > Save and restore the ARM KVM VGIC state from the kernel. We rely on > > static const VMStateDescription vmstate_gic = { > .name = "arm_gic", > -.version_id = 6, > -.minimum_version_id = 6, > +.version_id = 7, > +.minimum_version_id =

[Qemu-devel] [RFC PATCH v2 6/6] hw: arm_gic_kvm: Add KVM VGIC save/restore logic

2013-09-26 Thread Christoffer Dall
Save and restore the ARM KVM VGIC state from the kernel. We rely on QEMU to marshal the GICState data structure and therefore simply synchronize the kernel state with the QEMU emulated state in both directions. We take some care on the restore path to check the VGIC has been configured with enoug