Re: [Qemu-devel] [RFC PATCH v3 03/11] Add a script to extract VSS SDK headers on POSIX system

2013-05-24 Thread Laszlo Ersek
On 05/24/13 17:59, Eric Blake wrote: > On 05/24/2013 07:38 AM, Laszlo Ersek wrote: > >>> +++ b/scripts/extract-vsssdk-headers >>> @@ -0,0 +1,25 @@ >>> +#! /bin/bash >>> + > >>> +MAGIC=$'\xd0\xcf\x11\xe0\xa1\xb1\x1a\xe1' >> >> Can't help mentioning the following portable (alas, octal) equivalent :

Re: [Qemu-devel] [RFC PATCH v3 03/11] Add a script to extract VSS SDK headers on POSIX system

2013-05-24 Thread Eric Blake
On 05/24/2013 07:38 AM, Laszlo Ersek wrote: >> +++ b/scripts/extract-vsssdk-headers >> @@ -0,0 +1,25 @@ >> +#! /bin/bash >> + >> +MAGIC=$'\xd0\xcf\x11\xe0\xa1\xb1\x1a\xe1' > > Can't help mentioning the following portable (alas, octal) equivalent :) > > MAGIC=$(printf '%b' '\0320\0317\0021\0340\

Re: [Qemu-devel] [RFC PATCH v3 03/11] Add a script to extract VSS SDK headers on POSIX system

2013-05-24 Thread Laszlo Ersek
On 05/21/13 17:33, Tomoki Sekiyama wrote: > VSS SDK(*) setup.exe is only runnable on Windows. This adds a script > to extract VSS SDK headers on POSIX-systems using msitools. > > * http://www.microsoft.com/en-us/download/details.aspx?id=23490 > > From: Paolo Bonzini > Signed-off-by: Tomoki Sek

Re: [Qemu-devel] [RFC PATCH v3 03/11] Add a script to extract VSS SDK headers on POSIX system

2013-05-24 Thread Laszlo Ersek
On 05/21/13 23:02, Tomoki Sekiyama wrote: > Maybe it also should have an additional check and a message to install > Msitools for the case msiextract isn't exectable. Right. One POSIX-y way would be command -v msiextract >/dev/null and checking the exit status. http://pubs.opengroup.org/onli

Re: [Qemu-devel] [RFC PATCH v3 03/11] Add a script to extract VSS SDK headers on POSIX system

2013-05-21 Thread Tomoki Sekiyama
On 5/21/13 12:48 , "Eric Blake" wrote: >On 05/21/2013 09:33 AM, Tomoki Sekiyama wrote: >> VSS SDK(*) setup.exe is only runnable on Windows. This adds a script >> to extract VSS SDK headers on POSIX-systems using msitools. >> >> * http://www.microsoft.com/en-us/download/details.aspx?id=23490 >>

Re: [Qemu-devel] [RFC PATCH v3 03/11] Add a script to extract VSS SDK headers on POSIX system

2013-05-21 Thread Eric Blake
On 05/21/2013 09:33 AM, Tomoki Sekiyama wrote: > VSS SDK(*) setup.exe is only runnable on Windows. This adds a script > to extract VSS SDK headers on POSIX-systems using msitools. > > * http://www.microsoft.com/en-us/download/details.aspx?id=23490 > > From: Paolo Bonzini > Signed-off-by: Tomok

[Qemu-devel] [RFC PATCH v3 03/11] Add a script to extract VSS SDK headers on POSIX system

2013-05-21 Thread Tomoki Sekiyama
VSS SDK(*) setup.exe is only runnable on Windows. This adds a script to extract VSS SDK headers on POSIX-systems using msitools. * http://www.microsoft.com/en-us/download/details.aspx?id=23490 From: Paolo Bonzini Signed-off-by: Tomoki Sekiyama --- scripts/extract-vsssdk-headers | 25 ++