Re: [Qemu-devel] [RFC PATCH v3 1/3] vGPU Core driver

2016-05-12 Thread Tian, Kevin
Hi, Kirti/Neo, any response for below comment? > From: Tian, Kevin > Sent: Wednesday, May 04, 2016 10:59 AM > > > From: Alex Williamson > > Sent: Wednesday, May 04, 2016 6:44 AM > > > +/** > > > + * struct gpu_device_ops - Structure to be registered for each physical > > > GPU to > > > + *

Re: [Qemu-devel] [RFC PATCH v3 1/3] vGPU Core driver

2016-05-11 Thread Tian, Kevin
> From: Kirti Wankhede [mailto:kwankh...@nvidia.com] > Sent: Thursday, May 05, 2016 8:57 PM > > > On 5/5/2016 5:37 PM, Tian, Kevin wrote: > >> From: Kirti Wankhede [mailto:kwankh...@nvidia.com] > >> Sent: Thursday, May 05, 2016 6:45 PM > >> > >> > >> On 5/5/2016 2:36 PM, Tian, Kevin wrote: >

Re: [Qemu-devel] [RFC PATCH v3 1/3] vGPU Core driver

2016-05-09 Thread Jike Song
On 05/07/2016 12:16 AM, Kirti Wankhede wrote: > > > On 5/6/2016 5:44 PM, Jike Song wrote: >> On 05/05/2016 05:06 PM, Tian, Kevin wrote: From: Kirti Wankhede >> + * @validate_map_request: Validate remap pfn request >> + *@vdev: vgpu device

Re: [Qemu-devel] [RFC PATCH v3 1/3] vGPU Core driver

2016-05-06 Thread Kirti Wankhede
On 5/6/2016 5:44 PM, Jike Song wrote: > On 05/05/2016 05:06 PM, Tian, Kevin wrote: >>> From: Kirti Wankhede >>> >>> >> + * @validate_map_request: Validate remap pfn request >>> >> + * @vdev: vgpu device structure >>> >> + *

Re: [Qemu-devel] [RFC PATCH v3 1/3] vGPU Core driver

2016-05-06 Thread Jike Song
On 05/05/2016 05:06 PM, Tian, Kevin wrote: >> From: Kirti Wankhede >> >> >> + * @validate_map_request: Validate remap pfn request >> >> + * @vdev: vgpu device structure >> >> + * @virtaddr: target user address to start >> at >>

Re: [Qemu-devel] [RFC PATCH v3 1/3] vGPU Core driver

2016-05-05 Thread Kirti Wankhede
On 5/5/2016 5:37 PM, Tian, Kevin wrote: From: Kirti Wankhede [mailto:kwankh...@nvidia.com] Sent: Thursday, May 05, 2016 6:45 PM On 5/5/2016 2:36 PM, Tian, Kevin wrote: From: Kirti Wankhede Sent: Wednesday, May 04, 2016 9:32 PM Thanks Alex. >> +config VGPU_VFIO >> +tristate >> +

Re: [Qemu-devel] [RFC PATCH v3 1/3] vGPU Core driver

2016-05-05 Thread Tian, Kevin
> From: Kirti Wankhede [mailto:kwankh...@nvidia.com] > Sent: Thursday, May 05, 2016 6:45 PM > > > On 5/5/2016 2:36 PM, Tian, Kevin wrote: > >> From: Kirti Wankhede > >> Sent: Wednesday, May 04, 2016 9:32 PM > >> > >> Thanks Alex. > >> > >> >> +config VGPU_VFIO > >> >> +tristate > >> >> +

Re: [Qemu-devel] [RFC PATCH v3 1/3] vGPU Core driver

2016-05-05 Thread Kirti Wankhede
On 5/5/2016 2:36 PM, Tian, Kevin wrote: From: Kirti Wankhede Sent: Wednesday, May 04, 2016 9:32 PM Thanks Alex. >> +config VGPU_VFIO >> +tristate >> +depends on VGPU >> +default n >> + > > This is a little bit convoluted, it seems like everything added in this > patch is

Re: [Qemu-devel] [RFC PATCH v3 1/3] vGPU Core driver

2016-05-05 Thread Tian, Kevin
> From: Kirti Wankhede > Sent: Wednesday, May 04, 2016 9:32 PM > > Thanks Alex. > > >> +config VGPU_VFIO > >> +tristate > >> +depends on VGPU > >> +default n > >> + > > > > This is a little bit convoluted, it seems like everything added in this > > patch is vfio agnostic, it

Re: [Qemu-devel] [RFC PATCH v3 1/3] vGPU Core driver

2016-05-05 Thread Tian, Kevin
> From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Thursday, May 05, 2016 12:57 AM > > On Wed, 4 May 2016 02:45:59 + > "Tian, Kevin" wrote: > > > > From: Alex Williamson > > > Sent: Wednesday, May 04, 2016 6:44 AM > > > > > > > diff --git

Re: [Qemu-devel] [RFC PATCH v3 1/3] vGPU Core driver

2016-05-04 Thread Alex Williamson
On Wed, 4 May 2016 02:45:59 + "Tian, Kevin" wrote: > > From: Alex Williamson > > Sent: Wednesday, May 04, 2016 6:44 AM > > > > > diff --git a/drivers/vgpu/Kconfig b/drivers/vgpu/Kconfig > > > new file mode 100644 > > > index 000..792eb48 > > > --- /dev/null > > >

Re: [Qemu-devel] [RFC PATCH v3 1/3] vGPU Core driver

2016-05-04 Thread Kirti Wankhede
Thanks Alex. >> +config VGPU_VFIO >> +tristate >> +depends on VGPU >> +default n >> + > > This is a little bit convoluted, it seems like everything added in this > patch is vfio agnostic, it doesn't necessarily care what the consumer > is. That makes me think we should only be

Re: [Qemu-devel] [RFC PATCH v3 1/3] vGPU Core driver

2016-05-03 Thread Tian, Kevin
> From: Alex Williamson > Sent: Wednesday, May 04, 2016 6:44 AM > > +/** > > + * struct gpu_device_ops - Structure to be registered for each physical > > GPU to > > + * register the device to vgpu module. > > + * > > + * @owner: The module owner. > > + * @dev_attr_groups:

Re: [Qemu-devel] [RFC PATCH v3 1/3] vGPU Core driver

2016-05-03 Thread Tian, Kevin
> From: Alex Williamson > Sent: Wednesday, May 04, 2016 6:44 AM > > > diff --git a/drivers/vgpu/Kconfig b/drivers/vgpu/Kconfig > > new file mode 100644 > > index 000..792eb48 > > --- /dev/null > > +++ b/drivers/vgpu/Kconfig > > @@ -0,0 +1,21 @@ > > + > > +menuconfig VGPU > > +tristate

Re: [Qemu-devel] [RFC PATCH v3 1/3] vGPU Core driver

2016-05-03 Thread Alex Williamson
On Tue, 3 May 2016 00:10:39 +0530 Kirti Wankhede wrote: > Design for vGPU Driver: > Main purpose of vGPU driver is to provide a common interface for vGPU > management that can be used by differnt GPU drivers. > > This module would provide a generic interface to create the

[Qemu-devel] [RFC PATCH v3 1/3] vGPU Core driver

2016-05-02 Thread Kirti Wankhede
Design for vGPU Driver: Main purpose of vGPU driver is to provide a common interface for vGPU management that can be used by differnt GPU drivers. This module would provide a generic interface to create the device, add it to vGPU bus, add device to IOMMU group and then add it to vfio group. High