Re: [Qemu-devel] [RFC PATCH v4 13/30] piix_pci and pc_piix: refactor

2013-01-16 Thread Vasilis Liaskovitis
Hi, On Wed, Jan 16, 2013 at 12:17:05PM +0100, Andreas Färber wrote: > Hi, > > Am 16.01.2013 10:36, schrieb Vasilis Liaskovitis: > > On Wed, Jan 16, 2013 at 03:20:40PM +0800, Hu Tao wrote: > >> On Tue, Dec 18, 2012 at 01:41:41PM +0100, Vasilis Liaskovitis wrote: > >>> Refactor code so that chipset

Re: [Qemu-devel] [RFC PATCH v4 13/30] piix_pci and pc_piix: refactor

2013-01-16 Thread Andreas Färber
Hi, Am 16.01.2013 10:36, schrieb Vasilis Liaskovitis: > On Wed, Jan 16, 2013 at 03:20:40PM +0800, Hu Tao wrote: >> On Tue, Dec 18, 2012 at 01:41:41PM +0100, Vasilis Liaskovitis wrote: >>> Refactor code so that chipset initialization is similar to q35. This will >>> allow memory map initialization

Re: [Qemu-devel] [RFC PATCH v4 13/30] piix_pci and pc_piix: refactor

2013-01-16 Thread Vasilis Liaskovitis
Hi, On Wed, Jan 16, 2013 at 03:20:40PM +0800, Hu Tao wrote: > Hi Vasilis, > > On Tue, Dec 18, 2012 at 01:41:41PM +0100, Vasilis Liaskovitis wrote: > > Refactor code so that chipset initialization is similar to q35. This will > > allow memory map initialization at chipset qdev init time for both >

Re: [Qemu-devel] [RFC PATCH v4 13/30] piix_pci and pc_piix: refactor

2013-01-15 Thread Hu Tao
Hi Vasilis, On Tue, Dec 18, 2012 at 01:41:41PM +0100, Vasilis Liaskovitis wrote: > Refactor code so that chipset initialization is similar to q35. This will > allow memory map initialization at chipset qdev init time for both > machines, as well as more similar code structure overall. > > Signed-

[Qemu-devel] [RFC PATCH v4 13/30] piix_pci and pc_piix: refactor

2012-12-18 Thread Vasilis Liaskovitis
Refactor code so that chipset initialization is similar to q35. This will allow memory map initialization at chipset qdev init time for both machines, as well as more similar code structure overall. Signed-off-by: Vasilis Liaskovitis --- hw/pc_piix.c | 57 --- hw/piix_pci.c | 225