Re: [Qemu-devel] [RFC PATCH v4 2/5] kvm-all: Introduce kvm_set_singlestep

2019-03-12 Thread David Gibson
On Fri, Mar 08, 2019 at 04:09:56PM -0300, Fabiano Rosas wrote: > David Gibson writes: > > >> +/* Whether the KVM_SET_GUEST_DEBUG ioctl supports single stepping */ > >> +int kvm_has_guestdbg_singlestep(void) > >> +{ > >> +/* return kvm_check_extension(kvm_state, KVM_CAP_GUEST_DEBUG_SSTEP); >

Re: [Qemu-devel] [RFC PATCH v4 2/5] kvm-all: Introduce kvm_set_singlestep

2019-03-08 Thread Fabiano Rosas
David Gibson writes: >> +/* Whether the KVM_SET_GUEST_DEBUG ioctl supports single stepping */ >> +int kvm_has_guestdbg_singlestep(void) >> +{ >> +/* return kvm_check_extension(kvm_state, KVM_CAP_GUEST_DEBUG_SSTEP); */ > > I don't see a KVM_CAP_GUEST_DEBUG_SSTEP in either the qemu or kernel >

Re: [Qemu-devel] [RFC PATCH v4 2/5] kvm-all: Introduce kvm_set_singlestep

2019-03-04 Thread Fabiano Rosas
David Gibson writes: >> +/* Whether the KVM_SET_GUEST_DEBUG ioctl supports single stepping */ >> +int kvm_has_guestdbg_singlestep(void) >> +{ >> +/* return kvm_check_extension(kvm_state, KVM_CAP_GUEST_DEBUG_SSTEP); */ > > I don't see a KVM_CAP_GUEST_DEBUG_SSTEP in either the qemu or kernel >

Re: [Qemu-devel] [RFC PATCH v4 2/5] kvm-all: Introduce kvm_set_singlestep

2019-03-03 Thread David Gibson
On Thu, Feb 28, 2019 at 07:57:56PM -0300, Fabiano Rosas wrote: > For single stepping (via KVM) of a guest vcpu to work, KVM needs not > only to support the SET_GUEST_DEBUG ioctl but to also recognize the > KVM_GUESTDBG_SINGLESTEP bit in the control field of the > kvm_guest_debug struct. > > This

[Qemu-devel] [RFC PATCH v4 2/5] kvm-all: Introduce kvm_set_singlestep

2019-02-28 Thread Fabiano Rosas
For single stepping (via KVM) of a guest vcpu to work, KVM needs not only to support the SET_GUEST_DEBUG ioctl but to also recognize the KVM_GUESTDBG_SINGLESTEP bit in the control field of the kvm_guest_debug struct. This patch adds support for querying the single step capability so that QEMU can