Re: [Qemu-devel] [RFC PATCH v7 02/21] replay: global variables and function stubs

2015-01-20 Thread Eric Blake
On 01/12/2015 04:59 AM, Pavel Dovgalyuk wrote: This patch adds global variables, defines, functions declarations, and function stubs for deterministic VM replay used by external modules. Signed-off-by: Pavel Dovgalyuk pavel.dovga...@ispras.ru --- +++ b/qapi-schema.json @@ -3515,3 +3515,35

Re: [Qemu-devel] [RFC PATCH v7 02/21] replay: global variables and function stubs

2015-01-12 Thread Paolo Bonzini
On 12/01/2015 13:21, Pavel Dovgaluk wrote: +{ 'enum': 'ReplaySubmode', + 'data': [ 'unknown', 'normal' ] } What is a submode? Can you just check if replay_file is NULL? Submode is not very useful for these core patches. More submodes will be introduces in reverse debugging

Re: [Qemu-devel] [RFC PATCH v7 02/21] replay: global variables and function stubs

2015-01-12 Thread Pavel Dovgaluk
From: Paolo Bonzini [mailto:pbonz...@redhat.com] On 12/01/2015 12:59, Pavel Dovgalyuk wrote: +## +# ReplaySubmode: +# +# Submode of the replay subsystem. +# +# @unknown: used for modes different from play. +# +# @normal: normal replay mode. +# +# Since: 2.3 +## +{ 'enum':

Re: [Qemu-devel] [RFC PATCH v7 02/21] replay: global variables and function stubs

2015-01-12 Thread Paolo Bonzini
On 12/01/2015 12:59, Pavel Dovgalyuk wrote: +## +# ReplaySubmode: +# +# Submode of the replay subsystem. +# +# @unknown: used for modes different from play. +# +# @normal: normal replay mode. +# +# Since: 2.3 +## +{ 'enum': 'ReplaySubmode', + 'data': [ 'unknown', 'normal' ] } What

[Qemu-devel] [RFC PATCH v7 02/21] replay: global variables and function stubs

2015-01-12 Thread Pavel Dovgalyuk
This patch adds global variables, defines, functions declarations, and function stubs for deterministic VM replay used by external modules. Signed-off-by: Pavel Dovgalyuk pavel.dovga...@ispras.ru --- Makefile.target |1 + qapi-schema.json | 32