Re: [Qemu-devel] [RFC PATCH v8 08/21] cpu: replay instructions sequence

2015-02-17 Thread Paolo Bonzini
On 17/02/2015 09:43, Pavel Dovgaluk wrote: int64_t deadline = qemu_clock_deadline_ns_all(QEMU_CLOCK_VIRTUAL); if (deadline == 0) { qemu_clock_notify(QEMU_CLOCK_VIRTUAL); } instead of qemu_notify_event(), and remove these lines from qemu_tcg_cpu_thread_fn.

Re: [Qemu-devel] [RFC PATCH v8 08/21] cpu: replay instructions sequence

2015-02-17 Thread Pavel Dovgaluk
From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo Bonzini On 16/02/2015 14:37, Pavel Dovgaluk wrote: From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo Bonzini On 16/02/2015 14:27, Pavel Dovgaluk wrote: From: Paolo Bonzini

Re: [Qemu-devel] [RFC PATCH v8 08/21] cpu: replay instructions sequence

2015-02-17 Thread Pavel Dovgaluk
From: Paolo Bonzini [mailto:pbonz...@redhat.com] On 17/02/2015 09:43, Pavel Dovgaluk wrote: int64_t deadline = qemu_clock_deadline_ns_all(QEMU_CLOCK_VIRTUAL); if (deadline == 0) { qemu_clock_notify(QEMU_CLOCK_VIRTUAL); } instead of qemu_notify_event(),

Re: [Qemu-devel] [RFC PATCH v8 08/21] cpu: replay instructions sequence

2015-02-17 Thread Paolo Bonzini
On 17/02/2015 12:35, Pavel Dovgaluk wrote: How can I wake up iothread if there are no pending timers? deadline will (almost) never become zero in my case, because there is another kind of event in the log (not the timer one). Should I fetch the event and call qemu_notify_event() from replay

Re: [Qemu-devel] [RFC PATCH v8 08/21] cpu: replay instructions sequence

2015-02-16 Thread Paolo Bonzini
On 16/02/2015 13:26, Pavel Dovgaluk wrote: I think in this case there are no events at all - just reading timers values that were made while recording. We have to replay these reads by waking iothread. I think the right place for this is in replay_read_next_clock then. It

Re: [Qemu-devel] [RFC PATCH v8 08/21] cpu: replay instructions sequence

2015-02-16 Thread Pavel Dovgaluk
From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo Bonzini On 16/02/2015 14:27, Pavel Dovgaluk wrote: From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo Bonzini On 16/02/2015 13:26, Pavel Dovgaluk wrote: I think in this case there are no

Re: [Qemu-devel] [RFC PATCH v8 08/21] cpu: replay instructions sequence

2015-02-16 Thread Paolo Bonzini
On 16/02/2015 14:37, Pavel Dovgaluk wrote: From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo Bonzini On 16/02/2015 14:27, Pavel Dovgaluk wrote: From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo Bonzini On 16/02/2015 13:26, Pavel Dovgaluk wrote:

Re: [Qemu-devel] [RFC PATCH v8 08/21] cpu: replay instructions sequence

2015-02-16 Thread Paolo Bonzini
On 16/02/2015 14:27, Pavel Dovgaluk wrote: From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo Bonzini On 16/02/2015 13:26, Pavel Dovgaluk wrote: I think in this case there are no events at all - just reading timers values that were made while recording. We have to

Re: [Qemu-devel] [RFC PATCH v8 08/21] cpu: replay instructions sequence

2015-02-16 Thread Pavel Dovgaluk
From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo Bonzini On 02/02/2015 13:42, Pavel Dovgaluk wrote: From: Paolo Bonzini [mailto:pbonz...@redhat.com] On 02/02/2015 13:28, Pavel Dovgaluk wrote: cpu-exception_index = EXCP_INTERRUPT;

Re: [Qemu-devel] [RFC PATCH v8 08/21] cpu: replay instructions sequence

2015-02-16 Thread Pavel Dovgaluk
From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo Bonzini On 16/02/2015 13:26, Pavel Dovgaluk wrote: I think in this case there are no events at all - just reading timers values that were made while recording. We have to replay these reads by waking

Re: [Qemu-devel] [RFC PATCH v8 08/21] cpu: replay instructions sequence

2015-02-02 Thread Paolo Bonzini
On 02/02/2015 13:28, Pavel Dovgaluk wrote: cpu-exception_index = EXCP_INTERRUPT; next_tb = 0; +qemu_notify_event(); Why is this needed? It is needed to wake up iothread in replay mode. Otherwise

Re: [Qemu-devel] [RFC PATCH v8 08/21] cpu: replay instructions sequence

2015-02-02 Thread Paolo Bonzini
On 02/02/2015 13:42, Pavel Dovgaluk wrote: From: Paolo Bonzini [mailto:pbonz...@redhat.com] On 02/02/2015 13:28, Pavel Dovgaluk wrote: cpu-exception_index = EXCP_INTERRUPT; next_tb = 0; +

Re: [Qemu-devel] [RFC PATCH v8 08/21] cpu: replay instructions sequence

2015-02-02 Thread Pavel Dovgaluk
From: Paolo Bonzini [mailto:pbonz...@redhat.com] On 02/02/2015 13:28, Pavel Dovgaluk wrote: cpu-exception_index = EXCP_INTERRUPT; next_tb = 0; +qemu_notify_event(); Why is this needed? It is

Re: [Qemu-devel] [RFC PATCH v8 08/21] cpu: replay instructions sequence

2015-02-02 Thread Pavel Dovgaluk
From: Paolo Bonzini [mailto:pbonz...@redhat.com] On 22/01/2015 09:52, Pavel Dovgalyuk wrote: This patch adds calls to replay functions into the icount setup block. In record mode number of executed instructions is written to the log. In replay mode number of istructions to execute is taken

Re: [Qemu-devel] [RFC PATCH v8 08/21] cpu: replay instructions sequence

2015-01-29 Thread Paolo Bonzini
On 22/01/2015 09:52, Pavel Dovgalyuk wrote: This patch adds calls to replay functions into the icount setup block. In record mode number of executed instructions is written to the log. In replay mode number of istructions to execute is taken from the replay log. Signed-off-by: Pavel

[Qemu-devel] [RFC PATCH v8 08/21] cpu: replay instructions sequence

2015-01-22 Thread Pavel Dovgalyuk
This patch adds calls to replay functions into the icount setup block. In record mode number of executed instructions is written to the log. In replay mode number of istructions to execute is taken from the replay log. Signed-off-by: Pavel Dovgalyuk pavel.dovga...@ispras.ru --- cpu-exec.c |