Re: [Qemu-devel] [RFC PATCH v8 09/21] replay: interrupts and exceptions

2015-02-02 Thread Paolo Bonzini
On 02/02/2015 14:50, Pavel Dovgaluk wrote: > I think not. We just have to write number of already executed instructions. > This number is not linked to exception event. They could be read in replay > while > processing some other event. > I was referring to replay_put_event(EVENT_EXCEPTION) o

Re: [Qemu-devel] [RFC PATCH v8 09/21] replay: interrupts and exceptions

2015-02-02 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 22/01/2015 09:52, Pavel Dovgalyuk wrote: > > +if (replay_mode == REPLAY_MODE_RECORD) { > > +replay_save_instructions(); > > +replay_put_event(EVENT_EXCEPTION); > > +return true; > > Missing mutex lock/unlock. I th

Re: [Qemu-devel] [RFC PATCH v8 09/21] replay: interrupts and exceptions

2015-01-29 Thread Paolo Bonzini
On 22/01/2015 09:52, Pavel Dovgalyuk wrote: > +if (replay_mode == REPLAY_MODE_RECORD) { > +replay_save_instructions(); > +replay_put_event(EVENT_EXCEPTION); > +return true; Missing mutex lock/unlock. > +} else if (replay_mode == REPLAY_MODE_PLAY) { > +boo

[Qemu-devel] [RFC PATCH v8 09/21] replay: interrupts and exceptions

2015-01-22 Thread Pavel Dovgalyuk
This patch includes modifications of common cpu files. All interrupts and exceptions occured during recording are written into the replay log. These events allow correct replaying the execution by kicking cpu thread when one of these events is found in the log. Signed-off-by: Pavel Dovgalyuk ---