Re: [Qemu-devel] [RFC PATCH v8 21/21] replay: recording of the user input

2015-02-12 Thread Pavel Dovgaluk
From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo Bonzini On 22/01/2015 09:53, Pavel Dovgalyuk wrote: +if (replay_mode != REPLAY_MODE_PLAY) { +evt = qemu_input_event_new_key(key, down); +if (QTAILQ_EMPTY(kbd_queue)) { +

Re: [Qemu-devel] [RFC PATCH v8 21/21] replay: recording of the user input

2015-02-12 Thread Paolo Bonzini
On 12/02/2015 09:08, Pavel Dovgaluk wrote: This is wrong. You have different lifetimes for different modes. Please make a copy of the event in the implementation of record mode. What is the correct way for cloning the QAPI type? I should invent the cloning visitor or just create a

Re: [Qemu-devel] [RFC PATCH v8 21/21] replay: recording of the user input

2015-02-11 Thread Pavel Dovgaluk
From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo Bonzini On 22/01/2015 09:53, Pavel Dovgalyuk wrote: +void replay_input_event(QemuConsole *src, InputEvent *evt) +{ +if (replay_mode == REPLAY_MODE_PLAY) { +/* Nothing */ +} else if (replay_mode ==

Re: [Qemu-devel] [RFC PATCH v8 21/21] replay: recording of the user input

2015-01-30 Thread Paolo Bonzini
On 22/01/2015 09:53, Pavel Dovgalyuk wrote: +void replay_input_event(QemuConsole *src, InputEvent *evt) +{ +if (replay_mode == REPLAY_MODE_PLAY) { +/* Nothing */ +} else if (replay_mode == REPLAY_MODE_RECORD) { +replay_add_input_event(evt); Does

[Qemu-devel] [RFC PATCH v8 21/21] replay: recording of the user input

2015-01-22 Thread Pavel Dovgalyuk
This records user input (keyboard and mouse events) in record mode and replays these input events in replay mode. Signed-off-by: Pavel Dovgalyuk pavel.dovga...@ispras.ru --- include/ui/input.h |2 + replay/Makefile.objs |1 replay/replay-events.c | 55 +++