Re: [Qemu-devel] [RFC V1 10/14] qapi: Add support for deduplication infos in qapi-schema.json.

2013-01-17 Thread Eric Blake
On 01/17/2013 05:15 AM, Benoît Canet wrote: >> +# @running: True if deduplication is running > > Internally QCOW2 deduplication state switch between STOPPED, STARTING, RUNNING > and STOPPING. > > Should the running field be a status field reflecting all theses states in a > stri

Re: [Qemu-devel] [RFC V1 10/14] qapi: Add support for deduplication infos in qapi-schema.json.

2013-01-17 Thread Benoît Canet
> +# @running: True if deduplication is running Internally QCOW2 deduplication state switch between STOPPED, STARTING, RUNNING and STOPPING. Should the running field be a status field reflecting all theses states in a string for example ? Or is the boolean ok ? Regards Benoît

[Qemu-devel] [RFC V1 10/14] qapi: Add support for deduplication infos in qapi-schema.json.

2013-01-16 Thread Benoît Canet
--- qapi-schema.json | 40 +++- 1 file changed, 39 insertions(+), 1 deletion(-) diff --git a/qapi-schema.json b/qapi-schema.json index 5dfa052..1a5014c 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -720,6 +720,40 @@ { 'command': 'query-block', 'ret

Re: [Qemu-devel] [RFC V1 10/14] qapi: Add support for deduplication infos in qapi-schema.json.

2013-01-16 Thread Eric Blake
On 01/16/2013 09:25 AM, Benoît Canet wrote: > --- > qapi-schema.json | 40 +++- > 1 file changed, 39 insertions(+), 1 deletion(-) > > +# > +# @deleted-clusters: Number of deleted cluster when refcount < 0 Is it really when refcount goes negative, o