Re: [Qemu-devel] [RFC V6 07/11] quorum: Add quorum mechanism.

2013-01-18 Thread Benoît Canet
> Hmm, adler32() is basically a weak hashing mechanism; are you sure you > won't have any false collisions? Furthermore, how does this compare > with the series for adding deduplication, which uses much > stronger/longer hashes, but where those take more time to compute? Is > there any way you ca

Re: [Qemu-devel] [RFC V6 07/11] quorum: Add quorum mechanism.

2013-01-17 Thread Eric Blake
On 01/17/2013 08:51 AM, Benoît Canet wrote: > Signed-off-by: Benoit Canet > --- > block/quorum.c | 278 > +++- > 1 file changed, 277 insertions(+), 1 deletion(-) > > diff --git a/block/quorum.c b/block/quorum.c > index 98052eb..2b4 100644

[Qemu-devel] [RFC V6 07/11] quorum: Add quorum mechanism.

2013-01-17 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/quorum.c | 278 +++- 1 file changed, 277 insertions(+), 1 deletion(-) diff --git a/block/quorum.c b/block/quorum.c index 98052eb..2b4 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -14,6 +14,20 @@