Re: [Qemu-devel] [RFC for-2.7 1/1] block/qapi: Add query-block-node-tree

2016-03-29 Thread Max Reitz
On 29.03.2016 17:39, Eric Blake wrote: > On 03/29/2016 09:29 AM, Max Reitz wrote: > >> >> In my opinion, the way the order is explicitly represented is through >> every child's role. For quorum, "children.${i}" comes before >> "children.${i+1}". >> >> The general block layer does not care about th

Re: [Qemu-devel] [RFC for-2.7 1/1] block/qapi: Add query-block-node-tree

2016-03-29 Thread Eric Blake
On 03/29/2016 09:29 AM, Max Reitz wrote: > > In my opinion, the way the order is explicitly represented is through > every child's role. For quorum, "children.${i}" comes before > "children.${i+1}". > > The general block layer does not care about these generic children, it > only cares about "fi

Re: [Qemu-devel] [RFC for-2.7 1/1] block/qapi: Add query-block-node-tree

2016-03-29 Thread Max Reitz
On 28.03.2016 17:25, Eric Blake wrote: > On 03/26/2016 10:33 AM, Max Reitz wrote: > >>> We insert the new child to the head, not the tail... >> >> Well, the idea is that the order of children doesn't really matter; The >> only thing that describes the behavior of a child is its role. For >> instan

Re: [Qemu-devel] [RFC for-2.7 1/1] block/qapi: Add query-block-node-tree

2016-03-28 Thread Eric Blake
On 03/26/2016 10:33 AM, Max Reitz wrote: >> We insert the new child to the head, not the tail... > > Well, the idea is that the order of children doesn't really matter; The > only thing that describes the behavior of a child is its role. For > instance, for qcow2 it doesn't matter whether the "fi

Re: [Qemu-devel] [RFC for-2.7 1/1] block/qapi: Add query-block-node-tree

2016-03-26 Thread Max Reitz
On 25.03.2016 07:54, Wen Congyang wrote: > On 03/25/2016 03:07 AM, Max Reitz wrote: >> This command returns the tree of BlockDriverStates under a given root >> node. >> >> Every tree node is described by its node name and the connection of a >> parent node to its children additionally contains the

Re: [Qemu-devel] [RFC for-2.7 1/1] block/qapi: Add query-block-node-tree

2016-03-26 Thread Max Reitz
On 25.03.2016 03:50, Wen Congyang wrote: > On 03/25/2016 03:07 AM, Max Reitz wrote: >> This command returns the tree of BlockDriverStates under a given root >> node. >> >> Every tree node is described by its node name and the connection of a >> parent node to its children additionally contains the

Re: [Qemu-devel] [RFC for-2.7 1/1] block/qapi: Add query-block-node-tree

2016-03-24 Thread Wen Congyang
On 03/25/2016 03:07 AM, Max Reitz wrote: > This command returns the tree of BlockDriverStates under a given root > node. > > Every tree node is described by its node name and the connection of a > parent node to its children additionally contains the role the child > assumes. > > A node's name ca

Re: [Qemu-devel] [RFC for-2.7 1/1] block/qapi: Add query-block-node-tree

2016-03-24 Thread Wen Congyang
On 03/25/2016 03:07 AM, Max Reitz wrote: > This command returns the tree of BlockDriverStates under a given root > node. > > Every tree node is described by its node name and the connection of a > parent node to its children additionally contains the role the child > assumes. > > A node's name ca

[Qemu-devel] [RFC for-2.7 1/1] block/qapi: Add query-block-node-tree

2016-03-24 Thread Max Reitz
This command returns the tree of BlockDriverStates under a given root node. Every tree node is described by its node name and the connection of a parent node to its children additionally contains the role the child assumes. A node's name can then be used e.g. in conjunction with query-named-block