Re: [Qemu-devel] [RFC qom-cpu 03/15] target-i386: Update CPU to QOM realizefn

2013-01-17 Thread Eduardo Habkost
On Thu, Jan 17, 2013 at 09:03:59AM +0100, Andreas Färber wrote: [...] > >> I mentioned in the cover letter that this needs to be changed once a > >> CPUClass-level realizefn is introduced. I could introduce a no-op > >> realizefn there and do the regular store+call. > > > > That was the semantics

Re: [Qemu-devel] [RFC qom-cpu 03/15] target-i386: Update CPU to QOM realizefn

2013-01-17 Thread Andreas Färber
Am 17.01.2013 00:43, schrieb Eduardo Habkost: > On Wed, Jan 16, 2013 at 11:52:47PM +0100, Andreas Färber wrote: >> Am 16.01.2013 17:04, schrieb Eduardo Habkost: >>> On Wed, Jan 16, 2013 at 06:32:48AM +0100, Andreas Färber wrote: >>> [...] @@ -2247,6 +2247,9 @@ static void x86_cpu_common_class_

Re: [Qemu-devel] [RFC qom-cpu 03/15] target-i386: Update CPU to QOM realizefn

2013-01-16 Thread Eduardo Habkost
On Wed, Jan 16, 2013 at 11:52:47PM +0100, Andreas Färber wrote: > Am 16.01.2013 17:04, schrieb Eduardo Habkost: > > On Wed, Jan 16, 2013 at 06:32:48AM +0100, Andreas Färber wrote: > > [...] > >> @@ -2247,6 +2247,9 @@ static void x86_cpu_common_class_init(ObjectClass > >> *oc, void *data) > >> { >

Re: [Qemu-devel] [RFC qom-cpu 03/15] target-i386: Update CPU to QOM realizefn

2013-01-16 Thread Andreas Färber
Am 16.01.2013 17:04, schrieb Eduardo Habkost: > On Wed, Jan 16, 2013 at 06:32:48AM +0100, Andreas Färber wrote: > [...] >> @@ -2247,6 +2247,9 @@ static void x86_cpu_common_class_init(ObjectClass *oc, >> void *data) >> { >> X86CPUClass *xcc = X86_CPU_CLASS(oc); >> CPUClass *cc = CPU_CLAS

Re: [Qemu-devel] [RFC qom-cpu 03/15] target-i386: Update CPU to QOM realizefn

2013-01-16 Thread Eduardo Habkost
On Wed, Jan 16, 2013 at 06:32:48AM +0100, Andreas Färber wrote: [...] > @@ -2247,6 +2247,9 @@ static void x86_cpu_common_class_init(ObjectClass *oc, > void *data) > { > X86CPUClass *xcc = X86_CPU_CLASS(oc); > CPUClass *cc = CPU_CLASS(oc); > +DeviceClass *dc = DEVICE_CLASS(oc); > + >

Re: [Qemu-devel] [RFC qom-cpu 03/15] target-i386: Update CPU to QOM realizefn

2013-01-16 Thread Igor Mammedov
On Wed, 16 Jan 2013 06:32:48 +0100 Andreas Färber wrote: > Adapt the signature of x86_cpu_realize(), hook up to > DeviceClass::realize and set realized = true in cpu_x86_init(). > > Signed-off-by: Andreas Färber > Cc: Eduardo Habkost > Cc: Igor Mammedov Reviewed-By: Igor Mammedov > --- > t

[Qemu-devel] [RFC qom-cpu 03/15] target-i386: Update CPU to QOM realizefn

2013-01-15 Thread Andreas Färber
Adapt the signature of x86_cpu_realize(), hook up to DeviceClass::realize and set realized = true in cpu_x86_init(). Signed-off-by: Andreas Färber Cc: Eduardo Habkost Cc: Igor Mammedov --- target-i386/cpu-qom.h |3 --- target-i386/cpu.c |7 +-- target-i386/helper.c |2 +-