Re: [Qemu-devel] [RFC v1 1/1] virtio-crypto: Allow disabling of cipher algorithms for virtio-crypto device

2018-06-18 Thread Viktor VM Mihajlovski
On 15.06.2018 17:10, Farhan Ali wrote: > > > On 06/15/2018 09:17 AM, Viktor VM Mihajlovski wrote: [...] >> >> With the current virtio-crypto backend functionality offered (CBC AES >> only) it may seem a bit over-engineered to offer a configuration option >> to remove the only supported algorithm.

Re: [Qemu-devel] [RFC v1 1/1] virtio-crypto: Allow disabling of cipher algorithms for virtio-crypto device

2018-06-15 Thread Farhan Ali
On 06/15/2018 09:17 AM, Viktor VM Mihajlovski wrote: On 14.06.2018 18:12, Farhan Ali wrote: On 06/14/2018 11:10 AM, Daniel P. Berrangé wrote: On Thu, Jun 14, 2018 at 10:50:40AM -0400, Farhan Ali wrote: On 06/14/2018 04:21 AM, Daniel P. Berrangé wrote: On Wed, Jun 13, 2018 at 07:28:08PM

Re: [Qemu-devel] [RFC v1 1/1] virtio-crypto: Allow disabling of cipher algorithms for virtio-crypto device

2018-06-15 Thread Viktor VM Mihajlovski
On 14.06.2018 18:12, Farhan Ali wrote: > > > On 06/14/2018 11:10 AM, Daniel P. Berrangé wrote: >> On Thu, Jun 14, 2018 at 10:50:40AM -0400, Farhan Ali wrote: >>> >>> >>> On 06/14/2018 04:21 AM, Daniel P. Berrangé wrote: On Wed, Jun 13, 2018 at 07:28:08PM +0200, Halil Pasic wrote: > >

Re: [Qemu-devel] [RFC v1 1/1] virtio-crypto: Allow disabling of cipher algorithms for virtio-crypto device

2018-06-15 Thread Christian Borntraeger
On 06/13/2018 05:05 PM, Daniel P. Berrangé wrote: > On Wed, Jun 13, 2018 at 11:01:05AM -0400, Farhan Ali wrote: >> Hi Daniel >> >> On 06/13/2018 05:37 AM, Daniel P. Berrangé wrote: >>> On Tue, Jun 12, 2018 at 03:48:34PM -0400, Farhan Ali wrote: The virtio-crypto driver currently propagates

Re: [Qemu-devel] [RFC v1 1/1] virtio-crypto: Allow disabling of cipher algorithms for virtio-crypto device

2018-06-15 Thread Daniel P . Berrangé
nu.org; > > fran...@linux.ibm.com; m...@redhat.com; borntrae...@de.ibm.com; Gonglei > > (Arei) ; longpeng ; > > Viktor Mihajlovski ; > > mjros...@linux.vnet.ibm.com > > Subject: Re: [Qemu-devel] [RFC v1 1/1] virtio-crypto: Allow disabling of > > cipher > > a

Re: [Qemu-devel] [RFC v1 1/1] virtio-crypto: Allow disabling of cipher algorithms for virtio-crypto device

2018-06-14 Thread Gonglei (Arei)
; longpeng ; > Viktor Mihajlovski ; > mjros...@linux.vnet.ibm.com > Subject: Re: [Qemu-devel] [RFC v1 1/1] virtio-crypto: Allow disabling of > cipher > algorithms for virtio-crypto device > > On Thu, Jun 14, 2018 at 10:50:40AM -0400, Farhan Ali wrote: > > > > > >

Re: [Qemu-devel] [RFC v1 1/1] virtio-crypto: Allow disabling of cipher algorithms for virtio-crypto device

2018-06-14 Thread Daniel P . Berrangé
On Thu, Jun 14, 2018 at 12:12:23PM -0400, Farhan Ali wrote: > > > On 06/14/2018 11:10 AM, Daniel P. Berrangé wrote: > > On Thu, Jun 14, 2018 at 10:50:40AM -0400, Farhan Ali wrote: > > > > > > > > > On 06/14/2018 04:21 AM, Daniel P. Berrangé wrote: > > > > On Wed, Jun 13, 2018 at 07:28:08PM +020

Re: [Qemu-devel] [RFC v1 1/1] virtio-crypto: Allow disabling of cipher algorithms for virtio-crypto device

2018-06-14 Thread Farhan Ali
On 06/14/2018 11:10 AM, Daniel P. Berrangé wrote: On Thu, Jun 14, 2018 at 10:50:40AM -0400, Farhan Ali wrote: On 06/14/2018 04:21 AM, Daniel P. Berrangé wrote: On Wed, Jun 13, 2018 at 07:28:08PM +0200, Halil Pasic wrote: On 06/13/2018 05:05 PM, Daniel P. Berrangé wrote: On Wed, Jun 13,

Re: [Qemu-devel] [RFC v1 1/1] virtio-crypto: Allow disabling of cipher algorithms for virtio-crypto device

2018-06-14 Thread Daniel P . Berrangé
On Thu, Jun 14, 2018 at 10:50:40AM -0400, Farhan Ali wrote: > > > On 06/14/2018 04:21 AM, Daniel P. Berrangé wrote: > > On Wed, Jun 13, 2018 at 07:28:08PM +0200, Halil Pasic wrote: > > > > > > > > > On 06/13/2018 05:05 PM, Daniel P. Berrangé wrote: > > > > On Wed, Jun 13, 2018 at 11:01:05AM -04

Re: [Qemu-devel] [RFC v1 1/1] virtio-crypto: Allow disabling of cipher algorithms for virtio-crypto device

2018-06-14 Thread Farhan Ali
On 06/14/2018 04:21 AM, Daniel P. Berrangé wrote: On Wed, Jun 13, 2018 at 07:28:08PM +0200, Halil Pasic wrote: On 06/13/2018 05:05 PM, Daniel P. Berrangé wrote: On Wed, Jun 13, 2018 at 11:01:05AM -0400, Farhan Ali wrote: Hi Daniel On 06/13/2018 05:37 AM, Daniel P. Berrangé wrote: On Tue

Re: [Qemu-devel] [RFC v1 1/1] virtio-crypto: Allow disabling of cipher algorithms for virtio-crypto device

2018-06-14 Thread Daniel P . Berrangé
On Wed, Jun 13, 2018 at 07:28:08PM +0200, Halil Pasic wrote: > > > On 06/13/2018 05:05 PM, Daniel P. Berrangé wrote: > > On Wed, Jun 13, 2018 at 11:01:05AM -0400, Farhan Ali wrote: > > > Hi Daniel > > > > > > On 06/13/2018 05:37 AM, Daniel P. Berrangé wrote: > > > > On Tue, Jun 12, 2018 at 03:48

Re: [Qemu-devel] [RFC v1 1/1] virtio-crypto: Allow disabling of cipher algorithms for virtio-crypto device

2018-06-13 Thread Farhan Ali
Hi Arei On 06/12/2018 08:57 PM, Gonglei (Arei) wrote: -Original Message- From: Farhan Ali [mailto:al...@linux.ibm.com] Sent: Wednesday, June 13, 2018 3:49 AM To: qemu-devel@nongnu.org Cc: m...@redhat.com; Gonglei (Arei) ; longpeng ; pa...@linux.ibm.com; borntrae...@de.ibm.com; fran...@

Re: [Qemu-devel] [RFC v1 1/1] virtio-crypto: Allow disabling of cipher algorithms for virtio-crypto device

2018-06-13 Thread Halil Pasic
On 06/13/2018 05:05 PM, Daniel P. Berrangé wrote: On Wed, Jun 13, 2018 at 11:01:05AM -0400, Farhan Ali wrote: Hi Daniel On 06/13/2018 05:37 AM, Daniel P. Berrangé wrote: On Tue, Jun 12, 2018 at 03:48:34PM -0400, Farhan Ali wrote: The virtio-crypto driver currently propagates to the guest a

Re: [Qemu-devel] [RFC v1 1/1] virtio-crypto: Allow disabling of cipher algorithms for virtio-crypto device

2018-06-13 Thread Daniel P . Berrangé
On Wed, Jun 13, 2018 at 11:01:05AM -0400, Farhan Ali wrote: > Hi Daniel > > On 06/13/2018 05:37 AM, Daniel P. Berrangé wrote: > > On Tue, Jun 12, 2018 at 03:48:34PM -0400, Farhan Ali wrote: > > > The virtio-crypto driver currently propagates to the guest > > > all the cipher algorithms that the ba

Re: [Qemu-devel] [RFC v1 1/1] virtio-crypto: Allow disabling of cipher algorithms for virtio-crypto device

2018-06-13 Thread Farhan Ali
Hi Daniel On 06/13/2018 05:37 AM, Daniel P. Berrangé wrote: On Tue, Jun 12, 2018 at 03:48:34PM -0400, Farhan Ali wrote: The virtio-crypto driver currently propagates to the guest all the cipher algorithms that the backend cryptodev can support. But in certain cases where the guest has more perf

Re: [Qemu-devel] [RFC v1 1/1] virtio-crypto: Allow disabling of cipher algorithms for virtio-crypto device

2018-06-13 Thread Daniel P . Berrangé
On Tue, Jun 12, 2018 at 03:48:34PM -0400, Farhan Ali wrote: > The virtio-crypto driver currently propagates to the guest > all the cipher algorithms that the backend cryptodev can > support. But in certain cases where the guest has more > performant mechanism to handle some algorithms, it would be

Re: [Qemu-devel] [RFC v1 1/1] virtio-crypto: Allow disabling of cipher algorithms for virtio-crypto device

2018-06-12 Thread Gonglei (Arei)
> -Original Message- > From: Farhan Ali [mailto:al...@linux.ibm.com] > Sent: Wednesday, June 13, 2018 3:49 AM > To: qemu-devel@nongnu.org > Cc: m...@redhat.com; Gonglei (Arei) ; longpeng > ; pa...@linux.ibm.com; borntrae...@de.ibm.com; > fran...@linux.ibm.com; al...@linux.ibm.com > Subjec

[Qemu-devel] [RFC v1 1/1] virtio-crypto: Allow disabling of cipher algorithms for virtio-crypto device

2018-06-12 Thread Farhan Ali
The virtio-crypto driver currently propagates to the guest all the cipher algorithms that the backend cryptodev can support. But in certain cases where the guest has more performant mechanism to handle some algorithms, it would be useful to propagate only a subset of the algorithms. This patch add