Re: [Qemu-devel] [RFC v1 6/9] virtio-crypto: rework virtio_crypto_handle_request

2017-05-29 Thread Halil Pasic
On 05/18/2017 03:21 PM, Gonglei (Arei) wrote: Besides if you look at +Stateless mode HASH service requests are as follows: + +\begin{lstlisting} +struct virtio_crypto_hash_para_statelesss { +struct { +/* See VIRTIO_CRYPTO_HASH_* above */ +

Re: [Qemu-devel] [RFC v1 6/9] virtio-crypto: rework virtio_crypto_handle_request

2017-05-18 Thread Gonglei (Arei)
> > On 05/17/2017 11:12 AM, Gonglei (Arei) wrote: > >> From: Halil Pasic [mailto:pa...@linux.vnet.ibm.com] > >> Sent: Wednesday, May 17, 2017 6:18 AM > >> > >> > >> On 05/16/2017 04:52 AM, Gonglei (Arei) wrote: > On 05/13/2017 03:16 AM, Gonglei (Arei) wrote: > >> From: Halil Pasic

Re: [Qemu-devel] [RFC v1 6/9] virtio-crypto: rework virtio_crypto_handle_request

2017-05-18 Thread Halil Pasic
On 05/17/2017 11:12 AM, Gonglei (Arei) wrote: >> From: Halil Pasic [mailto:pa...@linux.vnet.ibm.com] >> Sent: Wednesday, May 17, 2017 6:18 AM >> >> >> On 05/16/2017 04:52 AM, Gonglei (Arei) wrote: On 05/13/2017 03:16 AM, Gonglei (Arei) wrote: >> From: Halil Pasic

Re: [Qemu-devel] [RFC v1 6/9] virtio-crypto: rework virtio_crypto_handle_request

2017-05-17 Thread Halil Pasic
On 05/17/2017 01:10 PM, Cornelia Huck wrote: > On Wed, 17 May 2017 12:33:20 +0200 > Halil Pasic wrote: > >> On 05/17/2017 12:13 PM, Gonglei (Arei) wrote: On 05/17/2017 11:12 AM, Gonglei (Arei) wrote: By the way, I'm having a hard time understing how

Re: [Qemu-devel] [RFC v1 6/9] virtio-crypto: rework virtio_crypto_handle_request

2017-05-17 Thread Cornelia Huck
On Wed, 17 May 2017 12:33:20 +0200 Halil Pasic wrote: > On 05/17/2017 12:13 PM, Gonglei (Arei) wrote: > >> > >> On 05/17/2017 11:12 AM, Gonglei (Arei) wrote: > >> By the way, I'm having a hard time understing how is the requirement > >> form > >> > > >>

Re: [Qemu-devel] [RFC v1 6/9] virtio-crypto: rework virtio_crypto_handle_request

2017-05-17 Thread Halil Pasic
On 05/17/2017 12:13 PM, Gonglei (Arei) wrote: >> >> On 05/17/2017 11:12 AM, Gonglei (Arei) wrote: >> By the way, I'm having a hard time understing how is the requirement >> form >> >> http://docs.oasis-open.org/virtio/virtio/v1.0/cs04/virtio-v1.0-cs04.html#x1-260 >> 004 >>

Re: [Qemu-devel] [RFC v1 6/9] virtio-crypto: rework virtio_crypto_handle_request

2017-05-17 Thread Gonglei (Arei)
> > On 05/17/2017 11:12 AM, Gonglei (Arei) wrote: > By the way, I'm having a hard time understing how is the requirement > form > > >> > http://docs.oasis-open.org/virtio/virtio/v1.0/cs04/virtio-v1.0-cs04.html#x1-260 > 004 > (2.4.4 Message Framing) satisfied by this code.

Re: [Qemu-devel] [RFC v1 6/9] virtio-crypto: rework virtio_crypto_handle_request

2017-05-17 Thread Halil Pasic
On 05/17/2017 11:12 AM, Gonglei (Arei) wrote: By the way, I'm having a hard time understing how is the requirement form >> http://docs.oasis-open.org/virtio/virtio/v1.0/cs04/virtio-v1.0-cs04.html#x1-260 004 (2.4.4 Message Framing) satisfied by this code. Could you explain

Re: [Qemu-devel] [RFC v1 6/9] virtio-crypto: rework virtio_crypto_handle_request

2017-05-17 Thread Gonglei (Arei)
> From: Halil Pasic [mailto:pa...@linux.vnet.ibm.com] > Sent: Wednesday, May 17, 2017 6:18 AM > > > On 05/16/2017 04:52 AM, Gonglei (Arei) wrote: > >> > >> On 05/13/2017 03:16 AM, Gonglei (Arei) wrote: > >>> > From: Halil Pasic [mailto:pa...@linux.vnet.ibm.com] > Sent: Friday, May 12,

Re: [Qemu-devel] [RFC v1 6/9] virtio-crypto: rework virtio_crypto_handle_request

2017-05-16 Thread Halil Pasic
On 05/16/2017 04:52 AM, Gonglei (Arei) wrote: >> >> On 05/13/2017 03:16 AM, Gonglei (Arei) wrote: >>> From: Halil Pasic [mailto:pa...@linux.vnet.ibm.com] Sent: Friday, May 12, 2017 7:02 PM On 05/08/2017 01:38 PM, Gonglei wrote: > According to the new spec, we should

Re: [Qemu-devel] [RFC v1 6/9] virtio-crypto: rework virtio_crypto_handle_request

2017-05-15 Thread Gonglei (Arei)
> > On 05/13/2017 03:16 AM, Gonglei (Arei) wrote: > > > >> From: Halil Pasic [mailto:pa...@linux.vnet.ibm.com] > >> Sent: Friday, May 12, 2017 7:02 PM > >> > >> > >> On 05/08/2017 01:38 PM, Gonglei wrote: > >>> According to the new spec, we should use different > >>> requst structure to store the

Re: [Qemu-devel] [RFC v1 6/9] virtio-crypto: rework virtio_crypto_handle_request

2017-05-15 Thread Halil Pasic
On 05/13/2017 03:16 AM, Gonglei (Arei) wrote: > >> From: Halil Pasic [mailto:pa...@linux.vnet.ibm.com] >> Sent: Friday, May 12, 2017 7:02 PM >> >> >> On 05/08/2017 01:38 PM, Gonglei wrote: >>> According to the new spec, we should use different >>> requst structure to store the data request

Re: [Qemu-devel] [RFC v1 6/9] virtio-crypto: rework virtio_crypto_handle_request

2017-05-12 Thread Gonglei (Arei)
> From: Halil Pasic [mailto:pa...@linux.vnet.ibm.com] > Sent: Friday, May 12, 2017 7:02 PM > > > On 05/08/2017 01:38 PM, Gonglei wrote: > > According to the new spec, we should use different > > requst structure to store the data request based > > on whether VIRTIO_CRYPTO_F_MUX_MODE feature bit

Re: [Qemu-devel] [RFC v1 6/9] virtio-crypto: rework virtio_crypto_handle_request

2017-05-12 Thread Halil Pasic
On 05/08/2017 01:38 PM, Gonglei wrote: > According to the new spec, we should use different > requst structure to store the data request based > on whether VIRTIO_CRYPTO_F_MUX_MODE feature bit is > negotiated or not. > > In this patch, we havn't supported stateless mode > yet. The device

[Qemu-devel] [RFC v1 6/9] virtio-crypto: rework virtio_crypto_handle_request

2017-05-08 Thread Gonglei
According to the new spec, we should use different requst structure to store the data request based on whether VIRTIO_CRYPTO_F_MUX_MODE feature bit is negotiated or not. In this patch, we havn't supported stateless mode yet. The device reportes an error if both VIRTIO_CRYPTO_F_MUX_MODE and