Re: [Qemu-devel] [RFC v3 PATCH 03/14] tcg/aarch64: Add support for fence

2016-06-23 Thread Alex Bennée
Richard Henderson writes: > On 06/23/2016 09:18 AM, Alex Bennée wrote: >>> > +/* System instructions. */ >>> > +DMB_ISH = 0xd50338bf, >> As ISH is part of the CRm encoding I wonder if this should be split into >> the main DMB encoding (0xd50330bf) and a

Re: [Qemu-devel] [RFC v3 PATCH 03/14] tcg/aarch64: Add support for fence

2016-06-23 Thread Richard Henderson
On 06/23/2016 09:18 AM, Alex Bennée wrote: > +/* System instructions. */ > +DMB_ISH = 0xd50338bf, As ISH is part of the CRm encoding I wonder if this should be split into the main DMB encoding (0xd50330bf) and a separate set of CRm defines. In fact the documentation of the

Re: [Qemu-devel] [RFC v3 PATCH 03/14] tcg/aarch64: Add support for fence

2016-06-23 Thread Alex Bennée
Pranith Kumar writes: > Cc: Claudio Fontana > Signed-off-by: Richard Henderson > Signed-off-by: Pranith Kumar > --- > tcg/aarch64/tcg-target.inc.c | 25 + > 1 file changed, 25

[Qemu-devel] [RFC v3 PATCH 03/14] tcg/aarch64: Add support for fence

2016-06-17 Thread Pranith Kumar
Cc: Claudio Fontana Signed-off-by: Richard Henderson Signed-off-by: Pranith Kumar --- tcg/aarch64/tcg-target.inc.c | 25 + 1 file changed, 25 insertions(+) diff --git a/tcg/aarch64/tcg-target.inc.c