Re: [Qemu-devel] [RFC v4 21/27] qmp: let migrate-incoming allow out-of-band

2017-11-27 Thread Peter Xu
On Mon, Nov 27, 2017 at 11:04:00AM +, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > On Mon, Nov 27, 2017 at 10:44:26AM +, Dr. David Alan Gilbert wrote: > > > > [...] > > > > > > > > > > > > But then I added a break on pthread_mutex_lock, and I've got > > > > >

Re: [Qemu-devel] [RFC v4 21/27] qmp: let migrate-incoming allow out-of-band

2017-11-27 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Mon, Nov 27, 2017 at 10:44:26AM +, Dr. David Alan Gilbert wrote: > > [...] > > > > > > > > > But then I added a break on pthread_mutex_lock, and I've got > > > > this set caused by qemu_start_incoming_migration sending a > > > > MIGRATION_STATUS_SET

Re: [Qemu-devel] [RFC v4 21/27] qmp: let migrate-incoming allow out-of-band

2017-11-27 Thread Peter Xu
On Mon, Nov 27, 2017 at 10:44:26AM +, Dr. David Alan Gilbert wrote: [...] > > > > > > But then I added a break on pthread_mutex_lock, and I've got > > > this set caused by qemu_start_incoming_migration sending a > > > MIGRATION_STATUS_SETUP event: > > > > > > #1 0x55ba6eba in qemu_

Re: [Qemu-devel] [RFC v4 21/27] qmp: let migrate-incoming allow out-of-band

2017-11-27 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Fri, Nov 24, 2017 at 01:14:53PM +, Dr. David Alan Gilbert wrote: > > * Peter Xu (pet...@redhat.com) wrote: > > > So it can get rid of being run on main thread. > > > > > > Signed-off-by: Peter Xu > > > > Last time I asked if you were sure that we di

Re: [Qemu-devel] [RFC v4 21/27] qmp: let migrate-incoming allow out-of-band

2017-11-26 Thread Peter Xu
On Fri, Nov 24, 2017 at 01:14:53PM +, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > So it can get rid of being run on main thread. > > > > Signed-off-by: Peter Xu > > Last time I asked if you were sure that we didn't do locking, > and you explained that we end up

Re: [Qemu-devel] [RFC v4 21/27] qmp: let migrate-incoming allow out-of-band

2017-11-24 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > So it can get rid of being run on main thread. > > Signed-off-by: Peter Xu Last time I asked if you were sure that we didn't do locking, and you explained that we end up just setting up a callback that happens in the mainloop, and this shouldn't take a loc

[Qemu-devel] [RFC v4 21/27] qmp: let migrate-incoming allow out-of-band

2017-11-16 Thread Peter Xu
So it can get rid of being run on main thread. Signed-off-by: Peter Xu --- qapi/migration.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qapi/migration.json b/qapi/migration.json index bbc4671ded..95098072dd 100644 --- a/qapi/migration.json +++ b/qapi/migration.json @