On 27/05/19 07:10, Markus Armbruster wrote:
>> Another suggestion: are there headers that cannot even be included once
>> (due to dependencies)? Is it worth including a test for those even in
>> the first iteration?
>>
> I'm not sure I get what you mean.
>
> Most headers failing the test fail it
Paolo Bonzini writes:
> On 23/05/19 21:57, Markus Armbruster wrote:
A large number of headers don't pass this test, by design or by
accident. To keep things more manageable, exclude all headers outside
include/ for now.
>>> A lot of these, either in include/ or outside, are
On 23/05/19 21:57, Markus Armbruster wrote:
>>> A large number of headers don't pass this test, by design or by
>>> accident. To keep things more manageable, exclude all headers outside
>>> include/ for now.
>> A lot of these, either in include/ or outside, are _meant_ to be
>> included many
Philippe Mathieu-Daudé writes:
> On 5/23/19 10:15 AM, Markus Armbruster wrote:
>> Make target check-source is for checking the source code itself. For
>> now, there's just one such check, make target check-headers. It
>> checks basic header sanity: for each header "FOO.h", test whether
>>
>>
On 5/23/19 10:15 AM, Markus Armbruster wrote:
> Make target check-source is for checking the source code itself. For
> now, there's just one such check, make target check-headers. It
> checks basic header sanity: for each header "FOO.h", test whether
>
> #include "qemu/osdep.h"
>
Paolo Bonzini writes:
> On 23/05/19 10:15, Markus Armbruster wrote:
>> A large number of headers don't pass this test, by design or by
>> accident. To keep things more manageable, exclude all headers outside
>> include/ for now.
>
> A lot of these, either in include/ or outside, are _meant_ to
On 23/05/19 10:15, Markus Armbruster wrote:
> A large number of headers don't pass this test, by design or by
> accident. To keep things more manageable, exclude all headers outside
> include/ for now.
A lot of these, either in include/ or outside, are _meant_ to be
included many times. What
Make target check-source is for checking the source code itself. For
now, there's just one such check, make target check-headers. It
checks basic header sanity: for each header "FOO.h", test whether
#include "qemu/osdep.h"
#include "FOO.h"
#include "FOO.h"
compiles.
