On Fri, Dec 15, 2017 at 09:53:53PM +0800, Fam Zheng wrote:
> On Fri, 12/15 13:26, Stefan Hajnoczi wrote:
> > > > QEMU always offers the 'oob' capability, even if the monitor does not
> > > > support it. Should it send 'oob' only when mon->use_io_thr to make
> > > > things easier for clients?
Agre
On Fri, 12/15 13:26, Stefan Hajnoczi wrote:
> > > QEMU always offers the 'oob' capability, even if the monitor does not
> > > support it. Should it send 'oob' only when mon->use_io_thr to make
> > > things easier for clients?
> >
> > So should we firstly agree on whether the capabilities is on th
On Fri, Dec 15, 2017 at 05:40:10PM +0800, Fam Zheng wrote:
> On Wed, 12/13 17:19, Stefan Hajnoczi wrote:
> > On Tue, Dec 05, 2017 at 01:51:46PM +0800, Peter Xu wrote:
> > > @@ -1037,8 +1038,42 @@ static void monitor_init_qmp_commands(void)
> > > qmp_marshal_qmp_capabilitie
On Wed, 12/13 17:19, Stefan Hajnoczi wrote:
> On Tue, Dec 05, 2017 at 01:51:46PM +0800, Peter Xu wrote:
> > @@ -1037,8 +1038,42 @@ static void monitor_init_qmp_commands(void)
> > qmp_marshal_qmp_capabilities, QCO_NO_OPTIONS);
> > }
> >
> > -void qmp_qmp_capabilities(Err
On Tue, Dec 05, 2017 at 01:51:46PM +0800, Peter Xu wrote:
> @@ -1037,8 +1038,42 @@ static void monitor_init_qmp_commands(void)
> qmp_marshal_qmp_capabilities, QCO_NO_OPTIONS);
> }
>
> -void qmp_qmp_capabilities(Error **errp)
> +static void qmp_caps_check(Monitor *mon, Q
* Peter Xu (pet...@redhat.com) wrote:
> After this patch, we will allow QMP clients to enable QMP capabilities
> when sending the first "qmp_capabilities" command. Originally we are
> starting QMP session with no arguments like:
>
> { "execute": "qmp_capabilities" }
>
> Now we can enable some
After this patch, we will allow QMP clients to enable QMP capabilities
when sending the first "qmp_capabilities" command. Originally we are
starting QMP session with no arguments like:
{ "execute": "qmp_capabilities" }
Now we can enable some QMP capabilities using (take OOB as example,
which i
