Re: [Qemu-devel] [RFC v6 1/2] virtio: introduce `query-virtio' QMP command

2017-12-20 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > Jan Dakinevich writes: > > > On Tue, 19 Dec 2017 15:57:18 +0100 > > Markus Armbruster wrote: > > > >> QAPI/QMP interface review only. > >> > >> You neglected to cc: the maintainers of qapi-schema.json, so I'm doing > >> that for you. > >> > > >

Re: [Qemu-devel] [RFC v6 1/2] virtio: introduce `query-virtio' QMP command

2017-12-20 Thread Cornelia Huck
On Wed, 20 Dec 2017 11:16:46 +0100 Markus Armbruster wrote: > Jan Dakinevich writes: > > > On Tue, 19 Dec 2017 15:57:18 +0100 > > Markus Armbruster wrote: > >> Jan Dakinevich writes: > Taking a step back: what's the intended purpose of query-virtio? The > cover letter doesn't really say: >

Re: [Qemu-devel] [RFC v6 1/2] virtio: introduce `query-virtio' QMP command

2017-12-20 Thread Markus Armbruster
Jan Dakinevich writes: > On Tue, 19 Dec 2017 15:57:18 +0100 > Markus Armbruster wrote: > >> QAPI/QMP interface review only. >> >> You neglected to cc: the maintainers of qapi-schema.json, so I'm doing >> that for you. >> > > Thank you so much. I screwed up with this patchset at least twice: wi

Re: [Qemu-devel] [RFC v6 1/2] virtio: introduce `query-virtio' QMP command

2017-12-19 Thread Jan Dakinevich
On Tue, 19 Dec 2017 15:57:18 +0100 Markus Armbruster wrote: > QAPI/QMP interface review only. > > You neglected to cc: the maintainers of qapi-schema.json, so I'm doing > that for you. > Thank you so much. I screwed up with this patchset at least twice: with list of maintainers and with my own

Re: [Qemu-devel] [RFC v6 1/2] virtio: introduce `query-virtio' QMP command

2017-12-19 Thread Markus Armbruster
QAPI/QMP interface review only. You neglected to cc: the maintainers of qapi-schema.json, so I'm doing that for you. Jan Dakinevich writes: > The command is intended for gathering virtio information such as status, > feature bits, negotiation status. It is convenient and useful for debug > purp

[Qemu-devel] [RFC v6 1/2] virtio: introduce `query-virtio' QMP command

2017-12-17 Thread Jan Dakinevich
The command is intended for gathering virtio information such as status, feature bits, negotiation status. It is convenient and useful for debug purpose. The commands returns generic virtio information for virtio such as common feature names and status bits names and information for all attached t