Re: [Qemu-devel] [RFC v6 21/27] qmp: support out-of-band (oob) execution

2018-01-12 Thread Stefan Hajnoczi
On Fri, Jan 12, 2018 at 02:23:51PM +0800, Peter Xu wrote: > Good to know the "?:" syntax... Thanks, It's a gcc extension and not part of the C standard: https://gcc.gnu.org/onlinedocs/gcc/Conditionals.html#Conditionals However, QEMU already uses it in several places so we can take advantage of

Re: [Qemu-devel] [RFC v6 21/27] qmp: support out-of-band (oob) execution

2018-01-11 Thread Peter Xu
On Tue, Jan 09, 2018 at 02:08:10PM +, Stefan Hajnoczi wrote: > On Tue, Dec 19, 2017 at 04:45:51PM +0800, Peter Xu wrote: > > diff --git a/monitor.c b/monitor.c > > index b571866659..505db439d8 100644 > > --- a/monitor.c > > +++ b/monitor.c > > @@ -1090,6 +1090,44 @@ static void

Re: [Qemu-devel] [RFC v6 21/27] qmp: support out-of-band (oob) execution

2018-01-09 Thread Stefan Hajnoczi
On Tue, Dec 19, 2017 at 04:45:51PM +0800, Peter Xu wrote: > diff --git a/monitor.c b/monitor.c > index b571866659..505db439d8 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -1090,6 +1090,44 @@ static void qmp_caps_apply(Monitor *mon, > QMPCapabilityList *list) > } > } > > +/* > + *

Re: [Qemu-devel] [RFC v6 21/27] qmp: support out-of-band (oob) execution

2017-12-21 Thread Fam Zheng
On Tue, 12/19 16:45, Peter Xu wrote: > Having "allow-oob" to true for a command does not mean that this command > will always be run in out-of-band mode. The out-of-band quick path will > only be executed if we specify the extra "run-oob" flag when sending the > QMP request: > > { "execute":

[Qemu-devel] [RFC v6 21/27] qmp: support out-of-band (oob) execution

2017-12-19 Thread Peter Xu
Having "allow-oob" to true for a command does not mean that this command will always be run in out-of-band mode. The out-of-band quick path will only be executed if we specify the extra "run-oob" flag when sending the QMP request: { "execute": "command-that-allows-oob", "arguments":