Re: [Qemu-devel] [RFT 0/4] Don't start virtqueues that are not enabled for vhost

2019-03-24 Thread Jason Wang
On 2019/3/24 下午6:53, Yuri Benditovich wrote: Hi Jason, This series does not do the job. Test case: tap, 4 queues, 2 CPU (so only 2 queues are enabled) For Q0 and Q1 vhost_net_start_one succeeds, For Q2: vhost_net_start_one calls vhost_dev_start (the call succeeds, does not start queue that is

Re: [Qemu-devel] [RFT 0/4] Don't start virtqueues that are not enabled for vhost

2019-03-24 Thread Yuri Benditovich
Hi Jason, This series does not do the job. Test case: tap, 4 queues, 2 CPU (so only 2 queues are enabled) For Q0 and Q1 vhost_net_start_one succeeds, For Q2: vhost_net_start_one calls vhost_dev_start (the call succeeds, does not start queue that is not enabled), then vhost_net_start_one calls

Re: [Qemu-devel] [RFT 0/4] Don't start virtqueues that are not enabled for vhost

2019-03-22 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190322092806.21838-1-jasow...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash

Re: [Qemu-devel] [RFT 0/4] Don't start virtqueues that are not enabled for vhost

2019-03-22 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190322092806.21838-1-jasow...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190322092806.21838-1-jasow...@redhat.com Subject: [Qemu-devel] [RFT 0/4] Don't start virtqueues

[Qemu-devel] [RFT 0/4] Don't start virtqueues that are not enabled for vhost

2019-03-22 Thread Jason Wang
Hi: This series try to avoid starting virtqueue that is not enabled. This is done through querying it through a bus specific way and skip the virtqueues if not enabled when starting vhost virtqueues. Only PCI is implemented, maybe it's better to move the enable flag to virito genenic virtqueue