Re: [Qemu-devel] [RISU v2 10/11] risu_reginfo_i386: replace xfeature constants with symbolic names

2019-05-20 Thread Alex Bennée
Jan Bobek writes: > The original code used "magic numbers", which made it unclear in > some places. Include a reference to the Intel manual where the > constants' meaning is discussed. > > Signed-off-by: Jan Bobek Reviewed-by: Alex Bennée > --- > risu_reginfo_i386.c | 48

Re: [Qemu-devel] [RISU v2 10/11] risu_reginfo_i386: replace xfeature constants with symbolic names

2019-05-18 Thread Richard Henderson
On 5/17/19 3:44 PM, Jan Bobek wrote: > The original code used "magic numbers", which made it unclear in > some places. Include a reference to the Intel manual where the > constants' meaning is discussed. > > Signed-off-by: Jan Bobek > --- > risu_reginfo_i386.c | 48

[Qemu-devel] [RISU v2 10/11] risu_reginfo_i386: replace xfeature constants with symbolic names

2019-05-17 Thread Jan Bobek
The original code used "magic numbers", which made it unclear in some places. Include a reference to the Intel manual where the constants' meaning is discussed. Signed-off-by: Jan Bobek --- risu_reginfo_i386.c | 48 +++-- 1 file changed, 33 insertions(+),