Re: [Qemu-devel] [RfC PATCH] vga: add mmio bar to standard vga

2012-09-22 Thread Blue Swirl
On Thu, Sep 20, 2012 at 5:43 AM, Gerd Hoffmann kra...@redhat.com wrote: Hi, +vbe_ioport_write_index(d-vga, 0, index); +return vbe_ioport_read_data(d-vga, 0); These functions are only available with CONFIG_BOCHS_VBE #defined, so this code should be conditional as well. But

Re: [Qemu-devel] [RfC PATCH] vga: add mmio bar to standard vga

2012-09-19 Thread Avi Kivity
On 09/18/2012 12:51 PM, Gerd Hoffmann wrote: This patch adds a mmio bar to the qemu standard vga which allows to access the standard vga registers and bochs dispi interface registers via mmio. diff --git a/hw/vga-pci.c b/hw/vga-pci.c index 9abbada..e05e2ef 100644 --- a/hw/vga-pci.c +++

Re: [Qemu-devel] [RfC PATCH] vga: add mmio bar to standard vga

2012-09-19 Thread Gerd Hoffmann
+ * 0x0400 - 0x041f vga ioports (0x3c0 - 0x3df), remapped 1:1 Do they support word accesses to set both index and data? + * 0x0500 - 0x0515 bochs dispi interface registers, mapped flat without + * index/data ports. Use (index 1) as offset for + *

Re: [Qemu-devel] [RfC PATCH] vga: add mmio bar to standard vga

2012-09-19 Thread Avi Kivity
On 09/19/2012 02:35 PM, Gerd Hoffmann wrote: Looks like word writes are supported provided the memory API breaks up writes in little endian order. Better to make it explicit. Like the attached incremental patch? Very like. -- error compiling committee.c: too many arguments to function

Re: [Qemu-devel] [RfC PATCH] vga: add mmio bar to standard vga

2012-09-19 Thread Blue Swirl
On Tue, Sep 18, 2012 at 9:51 AM, Gerd Hoffmann kra...@redhat.com wrote: This patch adds a mmio bar to the qemu standard vga which allows to access the standard vga registers and bochs dispi interface registers via mmio. Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Signed-off-by: Gerd

Re: [Qemu-devel] [RfC PATCH] vga: add mmio bar to standard vga

2012-09-19 Thread Gerd Hoffmann
Hi, +vbe_ioport_write_index(d-vga, 0, index); +return vbe_ioport_read_data(d-vga, 0); These functions are only available with CONFIG_BOCHS_VBE #defined, so this code should be conditional as well. But building without CONFIG_BOCHS_VBE is not very useful since it's used by the

[Qemu-devel] [RfC PATCH] vga: add mmio bar to standard vga

2012-09-18 Thread Gerd Hoffmann
This patch adds a mmio bar to the qemu standard vga which allows to access the standard vga registers and bochs dispi interface registers via mmio. Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/vga-pci.c | 97

Re: [Qemu-devel] [RfC PATCH] vga: add mmio bar to standard vga

2012-09-18 Thread Benjamin Herrenschmidt
On Tue, 2012-09-18 at 11:51 +0200, Gerd Hoffmann wrote: This patch adds a mmio bar to the qemu standard vga which allows to access the standard vga registers and bochs dispi interface registers via mmio. I had a patch like that somewhere (or is that it ? :-) I dropped it in favor of a more

Re: [Qemu-devel] [RfC PATCH] vga: add mmio bar to standard vga

2012-09-18 Thread Gerd Hoffmann
On 09/18/12 12:32, Benjamin Herrenschmidt wrote: On Tue, 2012-09-18 at 11:51 +0200, Gerd Hoffmann wrote: This patch adds a mmio bar to the qemu standard vga which allows to access the standard vga registers and bochs dispi interface registers via mmio. I had a patch like that somewhere (or