Re: [Qemu-devel] [Spice-devel] [PATCH] [RFC] LZ4 compression option for SPICE

2015-10-09 Thread Fabio Fantoni
Il 27/01/2015 09:26, Markus Armbruster ha scritto: > Eric Blake writes: > >> On 01/26/2015 01:48 AM, Javier Celaya wrote: >>> Sorry, I forgot to patch the command-line help. Hope it helps. >>> > Recently, SPICE included the lz4 compression algorithm. This patch adds > a

Re: [Qemu-devel] [Spice-devel] [PATCH] [RFC] LZ4 compression option for SPICE

2015-07-27 Thread Markus Armbruster
Fabio Fantoni fantonifa...@tiscali.it writes: Il 27/01/2015 09:26, Markus Armbruster ha scritto: Eric Blake ebl...@redhat.com writes: On 01/26/2015 01:48 AM, Javier Celaya wrote: Sorry, I forgot to patch the command-line help. Hope it helps. Recently, SPICE included the lz4 compression

Re: [Qemu-devel] [Spice-devel] [PATCH] [RFC] LZ4 compression option for SPICE

2015-07-24 Thread Fabio Fantoni
Il 27/01/2015 09:26, Markus Armbruster ha scritto: Eric Blake ebl...@redhat.com writes: On 01/26/2015 01:48 AM, Javier Celaya wrote: Sorry, I forgot to patch the command-line help. Hope it helps. Recently, SPICE included the lz4 compression algorithm. This patch adds a command line option

Re: [Qemu-devel] [Spice-devel] [PATCH] [RFC] LZ4 compression option for SPICE

2015-01-28 Thread Javier Celaya
From what I've seen in QEMU and libvirt's code, I would say that discovering whether the spice server supports LZ4 is not a matter of adding a new QMP command. That would not scale very well with new command line options. I would suggest something more general. For instance, having the command

Re: [Qemu-devel] [Spice-devel] [PATCH] [RFC] LZ4 compression option for SPICE

2015-01-28 Thread Markus Armbruster
Please don't top-quote. Javier Celaya javier.cel...@flexvm.es writes: El Martes, 27 de enero de 2015 09:26:11 Markus Armbruster escribió: Eric Blake ebl...@redhat.com writes: On 01/26/2015 01:48 AM, Javier Celaya wrote: Sorry, I forgot to patch the command-line help. Hope it helps.

Re: [Qemu-devel] [Spice-devel] [PATCH] [RFC] LZ4 compression option for SPICE

2015-01-27 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: On 01/26/2015 01:48 AM, Javier Celaya wrote: Sorry, I forgot to patch the command-line help. Hope it helps. Recently, SPICE included the lz4 compression algorithm. This patch adds a command line option to select it. How is libvirt going to

Re: [Qemu-devel] [Spice-devel] [PATCH] [RFC] LZ4 compression option for SPICE

2015-01-26 Thread Eric Blake
On 01/26/2015 01:48 AM, Javier Celaya wrote: Sorry, I forgot to patch the command-line help. Hope it helps. Recently, SPICE included the lz4 compression algorithm. This patch adds a command line option to select it. How is libvirt going to introspect whether the command line supports

Re: [Qemu-devel] [Spice-devel] [PATCH] [RFC] LZ4 compression option for SPICE

2015-01-26 Thread Javier Celaya
Sorry, I forgot to patch the command-line help. Hope it helps. El Viernes, 23 de enero de 2015 09:25:38 Eric Blake escribió: On 01/23/2015 07:06 AM, Javier Celaya wrote: Hello, this is the patch with the version check. Christophe, can you check that the version is the correct one?

Re: [Qemu-devel] [Spice-devel] [PATCH] [RFC] LZ4 compression option for SPICE

2015-01-23 Thread Javier Celaya
Hello, this is the patch with the version check. Christophe, can you check that the version is the correct one? El Martes, 20 de enero de 2015 17:08:07 Christophe Fergeau escribió: Hey, Version check seems good, we probably can raise spice-server version in git preemptively so that you can

Re: [Qemu-devel] [Spice-devel] [PATCH] [RFC] LZ4 compression option for SPICE

2015-01-23 Thread Eric Blake
On 01/23/2015 07:06 AM, Javier Celaya wrote: Hello, this is the patch with the version check. Christophe, can you check that the version is the correct one? Recently, SPICE included the lz4 compression algorithm. This patch adds a command line option to select it. --- ui/spice-core.c

Re: [Qemu-devel] [Spice-devel] [PATCH] [RFC] LZ4 compression option for SPICE

2015-01-20 Thread Christophe Fergeau
Hey, On Thu, Jan 08, 2015 at 11:50:13AM +0100, Javier Celaya wrote: Hello Recently, SPICE included the lz4 compression algorithm. This patch adds a command line option to select it. However, SPICE_IMAGE_COMPRESS_LZ4 did not exist before the commit that added this compression algorithm, so

Re: [Qemu-devel] [Spice-devel] [PATCH] [RFC] LZ4 compression option for SPICE

2015-01-08 Thread Fabio Fantoni
Il 08/01/2015 11:50, Javier Celaya ha scritto: Hello Recently, SPICE included the lz4 compression algorithm. This patch adds a command line option to select it. However, SPICE_IMAGE_COMPRESS_LZ4 did not exist before the commit that added this compression algorithm, so it should be

Re: [Qemu-devel] [Spice-devel] [PATCH] [RFC] LZ4 compression option for SPICE

2015-01-08 Thread Javier Celaya
Sure, for the help text of the image-compression option, thanks. El Jueves, 8 de enero de 2015 12:48:57 Fabio Fantoni escribió: Il 08/01/2015 11:50, Javier Celaya ha scritto: Hello Recently, SPICE included the lz4 compression algorithm. This patch adds a command line option to select