Re: [Qemu-devel] [V11 3/4] hw/core: provision for overriding emulated IOMMU

2016-05-24 Thread Marcel Apfelbaum
On 05/24/2016 04:01 PM, Jan Kiszka wrote: On 2016-05-24 13:49, Michael S. Tsirkin wrote: On Sun, May 22, 2016 at 01:21:53PM +0300, David Kiarie wrote: Added an enum, subject to review, to machine properties which it used to override iommu emulated from Intel to AMD. Signed-off-by: David Kiarie

Re: [Qemu-devel] [V11 3/4] hw/core: provision for overriding emulated IOMMU

2016-05-24 Thread Jan Kiszka
On 2016-05-24 13:49, Michael S. Tsirkin wrote: > On Sun, May 22, 2016 at 01:21:53PM +0300, David Kiarie wrote: >> Added an enum, subject to review, to machine properties which >> it used to override iommu emulated from Intel to AMD. >> >> Signed-off-by: David Kiarie > > Marcel's > "enable iommu

Re: [Qemu-devel] [V11 3/4] hw/core: provision for overriding emulated IOMMU

2016-05-24 Thread Michael S. Tsirkin
On Sun, May 22, 2016 at 01:21:53PM +0300, David Kiarie wrote: > Added an enum, subject to review, to machine properties which > it used to override iommu emulated from Intel to AMD. > > Signed-off-by: David Kiarie Marcel's "enable iommu with -device" seems like a better alternative. > --- > h

Re: [Qemu-devel] [V11 3/4] hw/core: provision for overriding emulated IOMMU

2016-05-23 Thread Peter Xu
On Sun, May 22, 2016 at 01:21:53PM +0300, David Kiarie wrote: [...] > static void machine_set_suppress_vmdesc(Object *obj, bool value, Error > **errp) > { > MachineState *ms = MACHINE(obj); > @@ -473,10 +492,14 @@ static void machine_initfn(Object *obj) >

[Qemu-devel] [V11 3/4] hw/core: provision for overriding emulated IOMMU

2016-05-22 Thread David Kiarie
Added an enum, subject to review, to machine properties which it used to override iommu emulated from Intel to AMD. Signed-off-by: David Kiarie --- hw/core/machine.c | 29 ++--- include/hw/boards.h | 1 + include/hw/i386/intel_iommu.h | 1 + qemu-o