Re: [Qemu-devel] [V3 PATCH 02/14] target-ppc: Add ISA2.06 bpermd Instruction

2013-12-30 Thread Richard Henderson
On 12/27/2013 04:23 PM, Scott Wood wrote: > On Tue, 2013-12-24 at 07:17 -0800, Richard Henderson wrote: >> On 12/18/2013 12:48 PM, Tom Musta wrote: >>> +DEF_HELPER_3(bpermd, i64, env, i64, i64) >> >> Should be DEF_HELPER_FLAGS_2(bpermd, TCG_CALL_NO_RWG_SE, i64, i64, i64) >> >>> +uint64_t helper_bpe

Re: [Qemu-devel] [V3 PATCH 02/14] target-ppc: Add ISA2.06 bpermd Instruction

2013-12-27 Thread Scott Wood
On Wed, 2013-12-18 at 14:48 -0600, Tom Musta wrote: > This patch adds the Bit Permute Doubleword (bpermd) instruction, > which was introduced in Power ISA 2.06 as part of the base 64-bit > architecture. Technically it's "Category: Embedded.Phased-in, Server" rather than "Category: Base". e5500 do

Re: [Qemu-devel] [V3 PATCH 02/14] target-ppc: Add ISA2.06 bpermd Instruction

2013-12-27 Thread Scott Wood
On Tue, 2013-12-24 at 07:17 -0800, Richard Henderson wrote: > On 12/18/2013 12:48 PM, Tom Musta wrote: > > +DEF_HELPER_3(bpermd, i64, env, i64, i64) > > Should be DEF_HELPER_FLAGS_2(bpermd, TCG_CALL_NO_RWG_SE, i64, i64, i64) > > > +uint64_t helper_bpermd(CPUPPCState *env, uint64_t rs, uint64_t rb

Re: [Qemu-devel] [V3 PATCH 02/14] target-ppc: Add ISA2.06 bpermd Instruction

2013-12-24 Thread Richard Henderson
On 12/18/2013 12:48 PM, Tom Musta wrote: > +DEF_HELPER_3(bpermd, i64, env, i64, i64) Should be DEF_HELPER_FLAGS_2(bpermd, TCG_CALL_NO_RWG_SE, i64, i64, i64) > +uint64_t helper_bpermd(CPUPPCState *env, uint64_t rs, uint64_t rb) > +{ > +int i; > +uint64_t ra = 0; > + > +for (i = 0; i <

[Qemu-devel] [V3 PATCH 02/14] target-ppc: Add ISA2.06 bpermd Instruction

2013-12-18 Thread Tom Musta
This patch adds the Bit Permute Doubleword (bpermd) instruction, which was introduced in Power ISA 2.06 as part of the base 64-bit architecture. V2: Addressing stylistic comments from Richard Henderson. Signed-off-by: Tom Musta Reviewed-by: Richard Henderson --- target-ppc/helper.h |1