Re: [Qemu-devel] [V7 1/1] fsdev: add IO throttle support to fsdev devices

2016-10-30 Thread Greg Kurz
On Sun, 30 Oct 2016 15:02:17 +0100 Pradeep Jagadeesh wrote: > On 10/30/2016 2:35 PM, Greg Kurz wrote: [...] > > > > I'll be AFK most of tomorrow and soft freeze starts next Tuesday... do you > > *really* need this to be in 2.8 ? > > > If everything is OK, then we can push into 2.8. I'm ok to i

Re: [Qemu-devel] [V7 1/1] fsdev: add IO throttle support to fsdev devices

2016-10-30 Thread Pradeep Jagadeesh
On 10/30/2016 2:35 PM, Greg Kurz wrote: On Sun, 30 Oct 2016 14:04:49 +0100 Pradeep Jagadeesh wrote: More remarks below. fsdev/Makefile.objs | 1 + fsdev/file-op-9p.h | 3 + fsdev/qemu-fsdev-opts.c | 76 +++ fsdev/qemu-fsdev-throttle.c | 147

Re: [Qemu-devel] [V7 1/1] fsdev: add IO throttle support to fsdev devices

2016-10-30 Thread Greg Kurz
On Sun, 30 Oct 2016 14:04:49 +0100 Pradeep Jagadeesh wrote: > >> More remarks below. > >> > >>> fsdev/Makefile.objs | 1 + > >>> fsdev/file-op-9p.h | 3 + > >>> fsdev/qemu-fsdev-opts.c | 76 +++ > >>> fsdev/qemu-fsdev-throttle.c | 147 > >>> +++

Re: [Qemu-devel] [V7 1/1] fsdev: add IO throttle support to fsdev devices

2016-10-30 Thread Pradeep Jagadeesh
More remarks below. fsdev/Makefile.objs | 1 + fsdev/file-op-9p.h | 3 + fsdev/qemu-fsdev-opts.c | 76 +++ fsdev/qemu-fsdev-throttle.c | 147 fsdev/qemu-fsdev-throttle.h | 37 +++ hw/9pfs/9p-lo

Re: [Qemu-devel] [V7 1/1] fsdev: add IO throttle support to fsdev devices

2016-10-30 Thread Pradeep Jagadeesh
diff --git a/fsdev/Makefile.objs b/fsdev/Makefile.objs index 1b120a4..2c6da2d 100644 --- a/fsdev/Makefile.objs +++ b/fsdev/Makefile.objs @@ -7,6 +7,7 @@ common-obj-y = qemu-fsdev-dummy.o endif common-obj-y += qemu-fsdev-opts.o +common-obj-y += qemu-fsdev-throttle.o (Optional) You can put

Re: [Qemu-devel] [V7 1/1] fsdev: add IO throttle support to fsdev devices

2016-10-25 Thread Pradeep Jagadeesh
On 10/24/2016 11:28 PM, Greg Kurz wrote: Re-post (I had hit the send button by error :) On Sat, 22 Oct 2016 11:07:22 -0400 Pradeep Jagadeesh wrote: Signed-off-by: Pradeep Jagadeesh --- Hi Pradeep, I see that Berto already did a thorough review for this patch and I agree for all the sugges

Re: [Qemu-devel] [V7 1/1] fsdev: add IO throttle support to fsdev devices

2016-10-25 Thread Pradeep Jagadeesh
On 10/24/2016 3:00 PM, Alberto Garcia wrote: On Sat 22 Oct 2016 05:07:22 PM CEST, Pradeep Jagadeesh wrote: This adds the support for the 9p-local driver. For now this functionality can be enabled only through qemu cli options. QMP interface and support to other drivers need further extensions

Re: [Qemu-devel] [V7 1/1] fsdev: add IO throttle support to fsdev devices

2016-10-24 Thread Greg Kurz
Re-post (I had hit the send button by error :) On Sat, 22 Oct 2016 11:07:22 -0400 Pradeep Jagadeesh wrote: > Signed-off-by: Pradeep Jagadeesh > --- Hi Pradeep, I see that Berto already did a thorough review for this patch and I agree for all the suggestions he made. I have some more to add.

Re: [Qemu-devel] [V7 1/1] fsdev: add IO throttle support to fsdev devices

2016-10-24 Thread Greg Kurz
On Sat, 22 Oct 2016 11:07:22 -0400 Pradeep Jagadeesh wrote: > Signed-off-by: Pradeep Jagadeesh > --- Hi Pradeep, I see that Berto already did a thorough review for this patch and I agree for all the suggestions he made. I have some more to add. First: this patch doesn't apply cleanly, please

Re: [Qemu-devel] [V7 1/1] fsdev: add IO throttle support to fsdev devices

2016-10-24 Thread Alberto Garcia
On Sat 22 Oct 2016 05:07:22 PM CEST, Pradeep Jagadeesh wrote: > This adds the support for the 9p-local driver. For now this > functionality can be enabled only through qemu cli options. QMP > interface and support to other drivers need further extensions. To > make it simple for other drivers,

[Qemu-devel] [V7 1/1] fsdev: add IO throttle support to fsdev devices

2016-10-22 Thread Pradeep Jagadeesh
Signed-off-by: Pradeep Jagadeesh --- fsdev/Makefile.objs | 1 + fsdev/file-op-9p.h | 3 + fsdev/qemu-fsdev-opts.c | 76 +++ fsdev/qemu-fsdev-throttle.c | 147 fsdev/qemu-fsdev-throttle.h | 37 +++