Re: [Qemu-devel] [WIP PATCH 00/24] IDE cleanups, initial work on AHCI rerror/werror=stop

2013-10-30 Thread Paolo Bonzini
Il 29/10/2013 19:30, Kevin Wolf ha scritto: > Am 28.10.2013 um 17:43 hat Paolo Bonzini geschrieben: >> Hi all, >> >> this is some cleanup to the IDE code that I started long ago >> and picked up again on my flight back from KVM Forum... >> >> The patches clean up the callbacks to prepare for implem

Re: [Qemu-devel] [WIP PATCH 00/24] IDE cleanups, initial work on AHCI rerror/werror=stop

2013-10-29 Thread Kevin Wolf
Am 28.10.2013 um 17:43 hat Paolo Bonzini geschrieben: > Hi all, > > this is some cleanup to the IDE code that I started long ago > and picked up again on my flight back from KVM Forum... > > The patches clean up the callbacks to prepare for implementing request > retry for AHCI. After these patc

Re: [Qemu-devel] [WIP PATCH 00/24] IDE cleanups, initial work on AHCI rerror/werror=stop

2013-10-29 Thread Paolo Bonzini
Il 28/10/2013 19:42, Michael S. Tsirkin ha scritto: > > > Hmm. Actually maybe there was an io error... is there > > > an easy way to find out? > > > > This would be a *host* I/O error, so I doubt. > > Yes, I know. Something like an out of range access on a disk > can trigger it perhaps? Yes, tha

Re: [Qemu-devel] [WIP PATCH 00/24] IDE cleanups, initial work on AHCI rerror/werror=stop

2013-10-28 Thread Michael S. Tsirkin
On Mon, Oct 28, 2013 at 07:36:32PM +0100, Paolo Bonzini wrote: > Il 28/10/2013 19:00, Michael S. Tsirkin ha scritto: > > > No, these are for another feature that is missing for AHCI, that is > > > support for stopping the VM on I/O errors. It is > > > https://bugzilla.redhat.com/show_bug.cgi?id=88

Re: [Qemu-devel] [WIP PATCH 00/24] IDE cleanups, initial work on AHCI rerror/werror=stop

2013-10-28 Thread Paolo Bonzini
Il 28/10/2013 19:00, Michael S. Tsirkin ha scritto: > > No, these are for another feature that is missing for AHCI, that is > > support for stopping the VM on I/O errors. It is > > https://bugzilla.redhat.com/show_bug.cgi?id=887844 > > Hmm. Actually maybe there was an io error... is there > an ea

Re: [Qemu-devel] [WIP PATCH 00/24] IDE cleanups, initial work on AHCI rerror/werror=stop

2013-10-28 Thread Michael S. Tsirkin
On Mon, Oct 28, 2013 at 06:26:58PM +0100, Paolo Bonzini wrote: > Il 28/10/2013 18:16, Michael S. Tsirkin ha scritto: > > On Mon, Oct 28, 2013 at 05:43:16PM +0100, Paolo Bonzini wrote: > >> Hi all, > >> > >> this is some cleanup to the IDE code that I started long ago > >> and picked up again on my

Re: [Qemu-devel] [WIP PATCH 00/24] IDE cleanups, initial work on AHCI rerror/werror=stop

2013-10-28 Thread Paolo Bonzini
Il 28/10/2013 18:16, Michael S. Tsirkin ha scritto: > On Mon, Oct 28, 2013 at 05:43:16PM +0100, Paolo Bonzini wrote: >> Hi all, >> >> this is some cleanup to the IDE code that I started long ago >> and picked up again on my flight back from KVM Forum... >> >> The patches clean up the callbacks to p

Re: [Qemu-devel] [WIP PATCH 00/24] IDE cleanups, initial work on AHCI rerror/werror=stop

2013-10-28 Thread Michael S. Tsirkin
On Mon, Oct 28, 2013 at 05:43:16PM +0100, Paolo Bonzini wrote: > Hi all, > > this is some cleanup to the IDE code that I started long ago > and picked up again on my flight back from KVM Forum... > > The patches clean up the callbacks to prepare for implementing request > retry for AHCI. After t

[Qemu-devel] [WIP PATCH 00/24] IDE cleanups, initial work on AHCI rerror/werror=stop

2013-10-28 Thread Paolo Bonzini
Hi all, this is some cleanup to the IDE code that I started long ago and picked up again on my flight back from KVM Forum... The patches clean up the callbacks to prepare for implementing request retry for AHCI. After these patches, PIO retry should work for AHCI and non-NCQ retry should be very