Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-11-04 Thread Chen, Tiejun
On 2014/11/3 21:10, Michael S. Tsirkin wrote: On Mon, Nov 03, 2014 at 01:01:03PM +0100, Paolo Bonzini wrote: On 03/11/2014 12:47, Chen, Tiejun wrote: On 2014/11/3 19:36, Chen, Tiejun wrote: On 2014/11/3 19:35, Paolo Bonzini wrote: On 03/11/2014 08:48, Chen, Tiejun wrote: I think the point

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-11-03 Thread Chen, Tiejun
On 2014/11/3 19:35, Paolo Bonzini wrote: On 03/11/2014 08:48, Chen, Tiejun wrote: I think the point was mostly to reserve 1f to prevent devices from using it. As we populate slots in order it doesn't seem to important ... If we populate slot at !1f GFX driver can't find this ISA bridge.

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-11-03 Thread Chen, Tiejun
On 2014/11/3 19:36, Chen, Tiejun wrote: On 2014/11/3 19:35, Paolo Bonzini wrote: On 03/11/2014 08:48, Chen, Tiejun wrote: I think the point was mostly to reserve 1f to prevent devices from using it. As we populate slots in order it doesn't seem to important ... If we populate slot at !1f GFX

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-11-03 Thread Paolo Bonzini
On 03/11/2014 12:47, Chen, Tiejun wrote: On 2014/11/3 19:36, Chen, Tiejun wrote: On 2014/11/3 19:35, Paolo Bonzini wrote: On 03/11/2014 08:48, Chen, Tiejun wrote: I think the point was mostly to reserve 1f to prevent devices from using it. As we populate slots in order it doesn't seem to

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-11-03 Thread Michael S. Tsirkin
On Mon, Nov 03, 2014 at 01:01:03PM +0100, Paolo Bonzini wrote: On 03/11/2014 12:47, Chen, Tiejun wrote: On 2014/11/3 19:36, Chen, Tiejun wrote: On 2014/11/3 19:35, Paolo Bonzini wrote: On 03/11/2014 08:48, Chen, Tiejun wrote: I think the point was mostly to reserve 1f to prevent

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-11-02 Thread Chen, Tiejun
On 2014/10/30 15:47, Chen, Tiejun wrote: Sorry some urgent things always procrastinate on my response. On 2014/10/24 21:47, Michael S. Tsirkin wrote: On Fri, Oct 24, 2014 at 03:36:20PM +0800, Chen, Tiejun wrote: I think the point was mostly to reserve 1f to prevent devices from using it. As

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-10-30 Thread Chen, Tiejun
Sorry some urgent things always procrastinate on my response. On 2014/10/24 21:47, Michael S. Tsirkin wrote: On Fri, Oct 24, 2014 at 03:36:20PM +0800, Chen, Tiejun wrote: I think the point was mostly to reserve 1f to prevent devices from using it. As we populate slots in order it doesn't seem

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-10-24 Thread Chen, Tiejun
: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough On 2014/9/1 14:05, Michael S. Tsirkin wrote: On Mon, Sep 01, 2014 at 10:50:37AM +0800, Chen, Tiejun wrote: On 2014/8/31 16:58, Michael S. Tsirkin wrote: On Fri, Aug 29, 2014 at 09:28:50AM +0800, Chen

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-10-24 Thread Michael S. Tsirkin
On Fri, Oct 24, 2014 at 03:36:20PM +0800, Chen, Tiejun wrote: I think the point was mostly to reserve 1f to prevent devices from using it. As we populate slots in order it doesn't seem to important ... If we populate slot at !1f GFX driver can't find this ISA bridge. Right, but I mean if no

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-10-12 Thread Michael S. Tsirkin
] xen:i386:pc_piix: create isa bridge specific to IGD passthrough On 2014/9/1 14:05, Michael S. Tsirkin wrote: On Mon, Sep 01, 2014 at 10:50:37AM +0800, Chen, Tiejun wrote: On 2014/8/31 16:58, Michael S. Tsirkin wrote: On Fri, Aug 29, 2014 at 09:28:50AM +0800, Chen, Tiejun wrote: On 2014/8/28 8

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-10-08 Thread Chen, Tiejun
On 2014/10/7 15:27, Michael S. Tsirkin wrote: On Sun, Sep 28, 2014 at 01:38:43PM +0800, Chen, Tiejun wrote: **errp) { uint32_t value = 0; XenHostPCIDevice hdev; int r = 0, num; r = xen_host_pci_device_get(hdev, 0, 0, 0x02, 0); if (!r) { value = hdev.device_id;

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-10-08 Thread Chen, Tiejun
: Chen, Tiejun Sent: Monday, September 01, 2014 12:50 AM To: Michael S. Tsirkin Cc: xen-de...@lists.xensource.com; Kay, Allen M; qemu-devel@nongnu.org; Konrad Rzeszutek Wilk Subject: Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough On 2014/9/1

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-10-07 Thread Michael S. Tsirkin
12:50 AM To: Michael S. Tsirkin Cc: xen-de...@lists.xensource.com; Kay, Allen M; qemu-devel@nongnu.org; Konrad Rzeszutek Wilk Subject: Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough On 2014/9/1 14:05, Michael S. Tsirkin wrote: On Mon

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-10-07 Thread Michael S. Tsirkin
On Sun, Sep 28, 2014 at 01:38:43PM +0800, Chen, Tiejun wrote: **errp) { uint32_t value = 0; XenHostPCIDevice hdev; int r = 0, num; r = xen_host_pci_device_get(hdev, 0, 0, 0x02, 0); if (!r) { value = hdev.device_id; num =

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-10-06 Thread Chen, Tiejun
12:50 AM To: Michael S. Tsirkin Cc: xen-de...@lists.xensource.com; Kay, Allen M; qemu-devel@nongnu.org; Konrad Rzeszutek Wilk Subject: Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough On 2014/9/1 14:05, Michael S. Tsirkin wrote: On Mon, Sep 01

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-09-29 Thread Michael S. Tsirkin
; Konrad Rzeszutek Wilk Subject: Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough On 2014/9/1 14:05, Michael S. Tsirkin wrote: On Mon, Sep 01, 2014 at 10:50:37AM +0800, Chen, Tiejun wrote: On 2014/8/31 16:58, Michael S. Tsirkin wrote: On Fri

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-09-29 Thread Chen, Tiejun
; Kay, Allen M; qemu-devel@nongnu.org; Konrad Rzeszutek Wilk Subject: Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough On 2014/9/1 14:05, Michael S. Tsirkin wrote: On Mon, Sep 01, 2014 at 10:50:37AM +0800, Chen, Tiejun wrote: On 2014/8/31 16

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-09-03 Thread Kay, Allen M
; qemu-devel@nongnu.org; Konrad Rzeszutek Wilk Subject: Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough On 2014/9/1 14:05, Michael S. Tsirkin wrote: On Mon, Sep 01, 2014 at 10:50:37AM +0800, Chen, Tiejun wrote: On 2014/8

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-09-02 Thread Kay, Allen M
-Original Message- From: Chen, Tiejun Sent: Monday, September 01, 2014 12:50 AM To: Michael S. Tsirkin Cc: xen-de...@lists.xensource.com; Kay, Allen M; qemu-devel@nongnu.org; Konrad Rzeszutek Wilk Subject: Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-09-02 Thread Michael S. Tsirkin
: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough On 2014/9/1 14:05, Michael S. Tsirkin wrote: On Mon, Sep 01, 2014 at 10:50:37AM +0800, Chen, Tiejun wrote: On 2014/8/31 16:58, Michael S. Tsirkin wrote: On Fri, Aug 29, 2014 at 09:28

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-09-01 Thread Michael S. Tsirkin
On Mon, Sep 01, 2014 at 10:50:37AM +0800, Chen, Tiejun wrote: On 2014/8/31 16:58, Michael S. Tsirkin wrote: On Fri, Aug 29, 2014 at 09:28:50AM +0800, Chen, Tiejun wrote: On 2014/8/28 8:56, Chen, Tiejun wrote: + */ +dev = pci_create_simple(bus, PCI_DEVFN(0x1f, 0), +

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-09-01 Thread Chen, Tiejun
On 2014/9/1 14:05, Michael S. Tsirkin wrote: On Mon, Sep 01, 2014 at 10:50:37AM +0800, Chen, Tiejun wrote: On 2014/8/31 16:58, Michael S. Tsirkin wrote: On Fri, Aug 29, 2014 at 09:28:50AM +0800, Chen, Tiejun wrote: On 2014/8/28 8:56, Chen, Tiejun wrote: + */ +dev =

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-08-31 Thread Michael S. Tsirkin
On Fri, Aug 29, 2014 at 09:28:50AM +0800, Chen, Tiejun wrote: On 2014/8/28 8:56, Chen, Tiejun wrote: + */ +dev = pci_create_simple(bus, PCI_DEVFN(0x1f, 0), +xen-igd-passthrough-isa-bridge); +if (dev) { +r = xen_host_pci_device_get(hdev, 0,

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-08-31 Thread Chen, Tiejun
On 2014/8/31 16:58, Michael S. Tsirkin wrote: On Fri, Aug 29, 2014 at 09:28:50AM +0800, Chen, Tiejun wrote: On 2014/8/28 8:56, Chen, Tiejun wrote: + */ +dev = pci_create_simple(bus, PCI_DEVFN(0x1f, 0), +xen-igd-passthrough-isa-bridge); +if (dev) { +

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-08-28 Thread Chen, Tiejun
On 2014/8/28 8:56, Chen, Tiejun wrote: + */ +dev = pci_create_simple(bus, PCI_DEVFN(0x1f, 0), +xen-igd-passthrough-isa-bridge); +if (dev) { +r = xen_host_pci_device_get(hdev, 0, 0, PCI_DEVFN(0x1f, 0), 0); +if (!r) { +

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-08-27 Thread Chen, Tiejun
+ */ +dev = pci_create_simple(bus, PCI_DEVFN(0x1f, 0), +xen-igd-passthrough-isa-bridge); +if (dev) { +r = xen_host_pci_device_get(hdev, 0, 0, PCI_DEVFN(0x1f, 0), 0); +if (!r) { +pci_config_set_vendor_id(dev-config,

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-08-25 Thread Chen, Tiejun
On 2014/8/25 13:18, Chen, Tiejun wrote: On 2014/8/24 19:12, Michael S. Tsirkin wrote: On Fri, Aug 22, 2014 at 09:06:20AM +0800, Chen, Tiejun wrote: On 2014/8/22 0:16, Konrad Rzeszutek Wilk wrote: On Thu, Aug 21, 2014 at 09:28:28AM +0800, Tiejun Chen wrote: Currenjly this ISA bridge should be

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-08-24 Thread Michael S. Tsirkin
On Fri, Aug 22, 2014 at 09:06:20AM +0800, Chen, Tiejun wrote: On 2014/8/22 0:16, Konrad Rzeszutek Wilk wrote: On Thu, Aug 21, 2014 at 09:28:28AM +0800, Tiejun Chen wrote: Currenjly this ISA bridge should be fixed at 1f.0, and pass the Currently Fixed. real vendor/device ids as the

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-08-24 Thread Chen, Tiejun
On 2014/8/24 19:12, Michael S. Tsirkin wrote: On Fri, Aug 22, 2014 at 09:06:20AM +0800, Chen, Tiejun wrote: On 2014/8/22 0:16, Konrad Rzeszutek Wilk wrote: On Thu, Aug 21, 2014 at 09:28:28AM +0800, Tiejun Chen wrote: Currenjly this ISA bridge should be fixed at 1f.0, and pass the Currently

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-08-21 Thread Konrad Rzeszutek Wilk
On Thu, Aug 21, 2014 at 09:28:28AM +0800, Tiejun Chen wrote: Currenjly this ISA bridge should be fixed at 1f.0, and pass the Currently real vendor/device ids as the driver expect. Could you add a bit more description to this patch please? Explain the rationale, etc. Signed-off-by: Tiejun

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-08-21 Thread Chen, Tiejun
On 2014/8/22 0:16, Konrad Rzeszutek Wilk wrote: On Thu, Aug 21, 2014 at 09:28:28AM +0800, Tiejun Chen wrote: Currenjly this ISA bridge should be fixed at 1f.0, and pass the Currently Fixed. real vendor/device ids as the driver expect. Could you add a bit more description to this patch