Re: [Qemu-devel] [for-2.12 1/7] pci: Rename root bus initialization functions for clarity

2017-12-01 Thread Peter Xu
On Fri, Dec 01, 2017 at 11:02:50AM +1100, David Gibson wrote: > On Thu, Nov 30, 2017 at 02:17:21PM +0800, Peter Xu wrote: > > On Wed, Nov 29, 2017 at 07:46:22PM +1100, David Gibson wrote: > > > pci_bus_init(), pci_bus_new_inplace(), pci_bus_new() and > > > pci_register_bus() > > > are misleadingly

Re: [Qemu-devel] [for-2.12 1/7] pci: Rename root bus initialization functions for clarity

2017-12-01 Thread David Gibson
On Thu, Nov 30, 2017 at 02:17:21PM +0800, Peter Xu wrote: > On Wed, Nov 29, 2017 at 07:46:22PM +1100, David Gibson wrote: > > pci_bus_init(), pci_bus_new_inplace(), pci_bus_new() and pci_register_bus() > > are misleadingly named. They're not used for initializing *any* PCI bus, > > but only for a

Re: [Qemu-devel] [for-2.12 1/7] pci: Rename root bus initialization functions for clarity

2017-11-29 Thread Peter Xu
On Wed, Nov 29, 2017 at 07:46:22PM +1100, David Gibson wrote: > pci_bus_init(), pci_bus_new_inplace(), pci_bus_new() and pci_register_bus() > are misleadingly named. They're not used for initializing *any* PCI bus, > but only for a root PCI bus. > > Non-root buses - i.e. ones under a logical PCI

Re: [Qemu-devel] [for-2.12 1/7] pci: Rename root bus initialization functions for clarity

2017-11-29 Thread Marcel Apfelbaum
Hi David, On 29/11/2017 10:46, David Gibson wrote: pci_bus_init(), pci_bus_new_inplace(), pci_bus_new() and pci_register_bus() are misleadingly named. They're not used for initializing *any* PCI bus, but only for a root PCI bus. Non-root buses - i.e. ones under a logical PCI to PCI bridge - ar

[Qemu-devel] [for-2.12 1/7] pci: Rename root bus initialization functions for clarity

2017-11-29 Thread David Gibson
pci_bus_init(), pci_bus_new_inplace(), pci_bus_new() and pci_register_bus() are misleadingly named. They're not used for initializing *any* PCI bus, but only for a root PCI bus. Non-root buses - i.e. ones under a logical PCI to PCI bridge - are instead created with a direct qbus_create_inplace()