On 11/25/2016 08:26 AM, Andrew Jones wrote:
> On Fri, Nov 25, 2016 at 12:32:24PM +, Andre Przywara wrote:
>> Hi Drew,
>>
>>
>>
>> On 23/11/16 17:15, Andrew Jones wrote:
> +
> +#if defined(__arm__)
I guess you should use the arch specific header files we have in place
>>
Hi,
On 25/11/16 14:26, Andrew Jones wrote:
> On Fri, Nov 25, 2016 at 12:32:24PM +, Andre Przywara wrote:
>> Hi Drew,
>>
>>
>>
>> On 23/11/16 17:15, Andrew Jones wrote:
> +
> +#if defined(__arm__)
I guess you should use the arch specific header files we have in place
On Fri, Nov 25, 2016 at 12:32:24PM +, Andre Przywara wrote:
> Hi Drew,
>
>
>
> On 23/11/16 17:15, Andrew Jones wrote:
> >>> +
> >>> +#if defined(__arm__)
> >>
> >> I guess you should use the arch specific header files we have in place
> >> for that (lib/arm{.64}/asm/processor.h). Also th
Hi Drew,
On 23/11/16 17:15, Andrew Jones wrote:
>>> +
>>> +#if defined(__arm__)
>>
>> I guess you should use the arch specific header files we have in place
>> for that (lib/arm{.64}/asm/processor.h). Also there are sysreg read
>> wrappers (at least for arm64) in there already, can't we base
On 11/23/2016 11:15 AM, Andrew Jones wrote:
> On Wed, Nov 23, 2016 at 01:16:08PM +, Andre Przywara wrote:
>> Hi,
>>
>> On 22/11/16 18:29, Wei Huang wrote:
>>> From: Christopher Covington
>>>
>>> Beginning with a simple sanity check of the control register, add
>>> a unit test for the ARM Per
On Wed, Nov 23, 2016 at 01:16:08PM +, Andre Przywara wrote:
> Hi,
>
> On 22/11/16 18:29, Wei Huang wrote:
> > From: Christopher Covington
> >
> > Beginning with a simple sanity check of the control register, add
> > a unit test for the ARM Performance Monitors Unit (PMU).
>
> Mmh, the outpu
On 11/23/2016 07:16 AM, Andre Przywara wrote:
> Hi,
>
> On 22/11/16 18:29, Wei Huang wrote:
>> From: Christopher Covington
>>
>> Beginning with a simple sanity check of the control register, add
>> a unit test for the ARM Performance Monitors Unit (PMU).
>
> Mmh, the output of this is a bit co
Hi,
On 22/11/16 18:29, Wei Huang wrote:
> From: Christopher Covington
>
> Beginning with a simple sanity check of the control register, add
> a unit test for the ARM Performance Monitors Unit (PMU).
Mmh, the output of this is a bit confusing. How about to join some
information? I changed it to
From: Christopher Covington
Beginning with a simple sanity check of the control register, add
a unit test for the ARM Performance Monitors Unit (PMU).
Signed-off-by: Christopher Covington
Signed-off-by: Wei Huang
Reviewed-by: Andrew Jones
---
arm/Makefile.common | 3 ++-
arm/pmu.c