Re: [Qemu-devel] [kvm-unit-tests PATCH v5 10/11] arm/arm64: gicv3: add an IPI test

2016-11-11 Thread Andre Przywara
Hi, On 11/11/16 14:53, Alex Bennée wrote: > > Andrew Jones writes: > >> On Fri, Nov 11, 2016 at 10:02:59AM +, Alex Bennée wrote: >>> >>> Andrew Jones writes: >>> On Thu, Nov 10, 2016 at 07:53:58PM +, Alex Bennée wrote: [...] >> +struct gic gicv2 = { >> +.ipi =

Re: [Qemu-devel] [kvm-unit-tests PATCH v5 10/11] arm/arm64: gicv3: add an IPI test

2016-11-11 Thread Alex Bennée
Andrew Jones writes: > On Fri, Nov 11, 2016 at 10:02:59AM +, Alex Bennée wrote: >> >> Andrew Jones writes: >> >> > On Thu, Nov 10, 2016 at 07:53:58PM +, Alex Bennée wrote: >> > [...] >> >> > +struct gic gicv2 = { >> >> > + .ipi = { >> >> > + .enable = gicv2_enable_de

Re: [Qemu-devel] [kvm-unit-tests PATCH v5 10/11] arm/arm64: gicv3: add an IPI test

2016-11-11 Thread Andrew Jones
On Fri, Nov 11, 2016 at 10:02:59AM +, Alex Bennée wrote: > > Andrew Jones writes: > > > On Thu, Nov 10, 2016 at 07:53:58PM +, Alex Bennée wrote: > > [...] > >> > +struct gic gicv2 = { > >> > +.ipi = { > >> > +.enable = gicv2_enable_defaults, > >> > +

Re: [Qemu-devel] [kvm-unit-tests PATCH v5 10/11] arm/arm64: gicv3: add an IPI test

2016-11-11 Thread Alex Bennée
Andrew Jones writes: > On Thu, Nov 10, 2016 at 07:53:58PM +, Alex Bennée wrote: > [...] >> > +struct gic gicv2 = { >> > + .ipi = { >> > + .enable = gicv2_enable_defaults, >> > + .send_self = gicv2_ipi_send_self, >> > + .send_tlist = gicv2_ipi_send_tlist, >> > +

Re: [Qemu-devel] [kvm-unit-tests PATCH v5 10/11] arm/arm64: gicv3: add an IPI test

2016-11-11 Thread Alex Bennée
Andre Przywara writes: > Hi, > > On 10/11/16 19:53, Alex Bennée wrote: > > >> So I was re-basing my kvm-unit-tests against your GIC rework and found >> myself copy and pasting a bunch of this into my tests that fire IRQs. > > So I take it you are working on (or already have) code to test SP

Re: [Qemu-devel] [kvm-unit-tests PATCH v5 10/11] arm/arm64: gicv3: add an IPI test

2016-11-11 Thread Andre Przywara
Hi, On 10/11/16 19:53, Alex Bennée wrote: > So I was re-basing my kvm-unit-tests against your GIC rework and found > myself copy and pasting a bunch of this into my tests that fire IRQs. So I take it you are working on (or already have) code to test SPIs, probably via GICD_ISPENDR? Just ask

Re: [Qemu-devel] [kvm-unit-tests PATCH v5 10/11] arm/arm64: gicv3: add an IPI test

2016-11-10 Thread Andrew Jones
On Thu, Nov 10, 2016 at 07:53:58PM +, Alex Bennée wrote: [...] > > +struct gic gicv2 = { > > + .ipi = { > > + .enable = gicv2_enable_defaults, > > + .send_self = gicv2_ipi_send_self, > > + .send_tlist = gicv2_ipi_send_tlist, > > + .send_broadcast = gicv

Re: [Qemu-devel] [kvm-unit-tests PATCH v5 10/11] arm/arm64: gicv3: add an IPI test

2016-11-10 Thread Alex Bennée
Andrew Jones writes: > Signed-off-by: Andrew Jones > > --- > v5: > - fix copy+paste error in gicv3_write_eoir [drew] > - use modern register names [Andre] > v4: > - heavily comment gicv3_ipi_send_tlist() [Eric] > - changes needed for gicv2 iar/irqstat fix to other patch > v2: > - use IRM f

[Qemu-devel] [kvm-unit-tests PATCH v5 10/11] arm/arm64: gicv3: add an IPI test

2016-11-10 Thread Andrew Jones
Signed-off-by: Andrew Jones --- v5: - fix copy+paste error in gicv3_write_eoir [drew] - use modern register names [Andre] v4: - heavily comment gicv3_ipi_send_tlist() [Eric] - changes needed for gicv2 iar/irqstat fix to other patch v2: - use IRM for gicv3 broadcast --- arm/gic.c