Re: [Qemu-devel] [patch] remove unused function arg in qemu_iohandler_poll() and qemu_iohandler_fill()

2011-11-02 Thread Stefan Hajnoczi
On Wed, Nov 2, 2011 at 1:46 AM, Jun Koi wrote: > On Tue, Nov 1, 2011 at 11:05 PM, Anthony Liguori > wrote: >> On 11/01/2011 12:11 AM, Jun Koi wrote: >>> >>> This patch removes unused function argument xfds from >>> qemu_iohandler_poll() and qemu_iohandler_fill() >>> >>> Signed-off-by: Jun Koi >>

Re: [Qemu-devel] [patch] remove unused function arg in qemu_iohandler_poll() and qemu_iohandler_fill()

2011-11-02 Thread Jun Koi
On Wed, Nov 2, 2011 at 3:40 PM, Paolo Bonzini wrote: > On 11/01/2011 06:11 AM, Jun Koi wrote: >> >> This patch removes unused function argument xfds from >> qemu_iohandler_poll() and qemu_iohandler_fill() > > I don't think the patch us particularly useful; the arguments are designed > to match sel

Re: [Qemu-devel] [patch] remove unused function arg in qemu_iohandler_poll() and qemu_iohandler_fill()

2011-11-02 Thread Paolo Bonzini
On 11/01/2011 06:11 AM, Jun Koi wrote: This patch removes unused function argument xfds from qemu_iohandler_poll() and qemu_iohandler_fill() I don't think the patch us particularly useful; the arguments are designed to match select. The fact that iohandlers do not support xfds (unlike e.g. g

Re: [Qemu-devel] [patch] remove unused function arg in qemu_iohandler_poll() and qemu_iohandler_fill()

2011-11-01 Thread Jun Koi
On Tue, Nov 1, 2011 at 11:05 PM, Anthony Liguori wrote: > On 11/01/2011 12:11 AM, Jun Koi wrote: >> >> This patch removes unused function argument xfds from >> qemu_iohandler_poll() and qemu_iohandler_fill() >> >> Signed-off-by: Jun Koi >> > > Your mailer is munging the patch.  Please use git-send

Re: [Qemu-devel] [patch] remove unused function arg in qemu_iohandler_poll() and qemu_iohandler_fill()

2011-11-01 Thread Anthony Liguori
On 11/01/2011 12:11 AM, Jun Koi wrote: This patch removes unused function argument xfds from qemu_iohandler_poll() and qemu_iohandler_fill() Signed-off-by: Jun Koi diff --git a/iohandler.c b/iohandler.c index 5640d49..9963790 100644 --- a/iohandler.c +++ b/iohandler.c @@ -89,7 +89,7 @@ int qem

[Qemu-devel] [patch] remove unused function arg in qemu_iohandler_poll() and qemu_iohandler_fill()

2011-10-31 Thread Jun Koi
This patch removes unused function argument xfds from qemu_iohandler_poll() and qemu_iohandler_fill() Signed-off-by: Jun Koi diff --git a/iohandler.c b/iohandler.c index 5640d49..9963790 100644 --- a/iohandler.c +++ b/iohandler.c @@ -89,7 +89,7 @@ int qemu_set_fd_handler(int fd, return qem