Re: [Qemu-devel] [patch] target-alpha: squashed fpu qualifiers patch

2009-12-28 Thread Richard Henderson
On 12/24/2009 07:18 AM, Aurelien Jarno wrote: My main concern about this patch is that I don't really understand why the current fp exceptions, the current rounding mode or flush_to_zero mode are stored in FP_STATUS. I think it would be better to have dedicated variable(s) in the cpu state struct

Re: [Qemu-devel] [patch] target-alpha: squashed fpu qualifiers patch

2009-12-28 Thread Aurelien Jarno
On Mon, Dec 28, 2009 at 08:52:28PM +0100, Aurelien Jarno wrote: > On Mon, Dec 28, 2009 at 08:48:22PM +0100, Aurelien Jarno wrote: > > On Mon, Dec 28, 2009 at 11:06:20AM -0800, Richard Henderson wrote: > > > On 12/24/2009 07:18 AM, Aurelien Jarno wrote: > > >> My main concern about this patch is tha

Re: [Qemu-devel] [patch] target-alpha: squashed fpu qualifiers patch

2009-12-28 Thread Aurelien Jarno
On Mon, Dec 28, 2009 at 08:48:22PM +0100, Aurelien Jarno wrote: > On Mon, Dec 28, 2009 at 11:06:20AM -0800, Richard Henderson wrote: > > On 12/24/2009 07:18 AM, Aurelien Jarno wrote: > >> My main concern about this patch is that I don't really understand why > >> the current fp exceptions, the curr

Re: [Qemu-devel] [patch] target-alpha: squashed fpu qualifiers patch

2009-12-28 Thread Aurelien Jarno
On Mon, Dec 28, 2009 at 11:06:20AM -0800, Richard Henderson wrote: > On 12/24/2009 07:18 AM, Aurelien Jarno wrote: >> My main concern about this patch is that I don't really understand why >> the current fp exceptions, the current rounding mode or flush_to_zero >> mode are stored in FP_STATUS. I th

Re: [Qemu-devel] [patch] target-alpha: squashed fpu qualifiers patch

2009-12-24 Thread Aurelien Jarno
On Fri, Dec 18, 2009 at 02:09:09PM -0800, Richard Henderson wrote: > This is a squashed version of the 3 or 4 incremental patches that I > had sent out for implementing the alpha fpu instruction qualifiers. > > First of all, this patch has a lot of coding style issues. I have reported some of th