Re: [Qemu-devel] [qemu-s390x] [PATCH] hw/s390x/virtio-ccw.c: Don't take address of fields in packed structs

2018-12-10 Thread Cornelia Huck
On Mon, 10 Dec 2018 14:06:42 +0100 Halil Pasic wrote: > On Mon, 10 Dec 2018 12:04:36 + > Peter Maydell wrote: > > > Taking the address of a field in a packed struct is a bad idea, because > > it might not be actually aligned enough for that pointer type (and > > thus cause a crash on

Re: [Qemu-devel] [qemu-s390x] [PATCH] hw/s390x/virtio-ccw.c: Don't take address of fields in packed structs

2018-12-10 Thread Halil Pasic
On Mon, 10 Dec 2018 12:04:36 + Peter Maydell wrote: > Taking the address of a field in a packed struct is a bad idea, because > it might not be actually aligned enough for that pointer type (and > thus cause a crash on dereference on some host architectures). Newer > versions of clang warn