Re: [Qemu-devel] [qemu-s390x] [PATCH v1 3/4] s390x/zpci: move some hotplug checks to the pre_plug handler

2018-11-07 Thread Collin Walling
On 11/7/18 2:36 PM, David Hildenbrand wrote: >> >> When did these function names drop the *_hot_plug postfix? Latest master >> does not reflect this change for me. >> Just figured I'd mention it now in case merging becomes a pain later ;) >> > > Mentioned it in the cover letter, part of another

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 3/4] s390x/zpci: move some hotplug checks to the pre_plug handler

2018-11-07 Thread David Hildenbrand
> > When did these function names drop the *_hot_plug postfix? Latest master does > not reflect this change for me. > Just figured I'd mention it now in case merging becomes a pain later ;) > Mentioned it in the cover letter, part of another series (also CC'ed to qemu-s3...@nongnu.org, so

Re: [Qemu-devel] [qemu-s390x] [PATCH v1 3/4] s390x/zpci: move some hotplug checks to the pre_plug handler

2018-11-07 Thread Collin Walling
On 11/5/18 6:50 AM, David Hildenbrand wrote: > On 05.11.18 12:03, David Hildenbrand wrote: >> Let's move most of the checks to the new pre_plug handler. As a PCI >> bridge is just a PCI device, we can simplify the code. >> >> Notes: We cannot yet move the MSIX check or device ID creation + >> zPCI