Re: [Qemu-devel] [qemu-s390x] [RFC PATCH 1/3] hw/Kconfig: PCI bus implies PCI_DEVICES

2019-07-22 Thread Markus Armbruster
Thomas Huth writes: > On 16/07/2019 15.06, Markus Armbruster wrote: [...] >> 2. We want a way to Kconfig the PCI devices that work, i.e. only the >>ones that support MSI or MSI-X. >> >> I don't like calling devices without any MSI capability "classic" or >> "conventional devices". I'd rathe

Re: [Qemu-devel] [qemu-s390x] [RFC PATCH 1/3] hw/Kconfig: PCI bus implies PCI_DEVICES

2019-07-18 Thread Cornelia Huck
On Wed, 17 Jul 2019 17:04:54 +0200 Paolo Bonzini wrote: > On 17/07/19 16:54, Collin Walling wrote: > > PCI host plugging will check for the MSI-X capability on the > > PCI device. If the MSI-X cap is missing, we fail device plugging. > > We do not check for MSI. Only MSI-X. > > > > Specifically,

Re: [Qemu-devel] [qemu-s390x] [RFC PATCH 1/3] hw/Kconfig: PCI bus implies PCI_DEVICES

2019-07-17 Thread Paolo Bonzini
On 17/07/19 16:54, Collin Walling wrote: > PCI host plugging will check for the MSI-X capability on the > PCI device. If the MSI-X cap is missing, we fail device plugging. > We do not check for MSI. Only MSI-X. > > Specifically, the capability is represented by PCI_CAP_ID_MSIX > in pci_regs.h The

Re: [Qemu-devel] [qemu-s390x] [RFC PATCH 1/3] hw/Kconfig: PCI bus implies PCI_DEVICES

2019-07-17 Thread Collin Walling
On 7/17/19 9:52 AM, Paolo Bonzini wrote: On 17/07/19 14:59, Collin Walling wrote: On 7/16/19 11:04 AM, Thomas Huth wrote: On 16/07/2019 15.06, Markus Armbruster wrote: Paolo Bonzini writes: On 15/07/19 18:12, Cornelia Huck wrote: Is it INTx vs. MSI vs. MSI-X? I think for s390x we need (I

Re: [Qemu-devel] [qemu-s390x] [RFC PATCH 1/3] hw/Kconfig: PCI bus implies PCI_DEVICES

2019-07-17 Thread Paolo Bonzini
On 17/07/19 14:59, Collin Walling wrote: > On 7/16/19 11:04 AM, Thomas Huth wrote: >> On 16/07/2019 15.06, Markus Armbruster wrote: >>> Paolo Bonzini writes: >>> On 15/07/19 18:12, Cornelia Huck wrote: >> Is it INTx vs. MSI vs. MSI-X? > > I think for s390x we need (INTx || MSI) vs

Re: [Qemu-devel] [qemu-s390x] [RFC PATCH 1/3] hw/Kconfig: PCI bus implies PCI_DEVICES

2019-07-17 Thread Collin Walling
On 7/16/19 11:04 AM, Thomas Huth wrote: On 16/07/2019 15.06, Markus Armbruster wrote: Paolo Bonzini writes: On 15/07/19 18:12, Cornelia Huck wrote: Is it INTx vs. MSI vs. MSI-X? I think for s390x we need (INTx || MSI) vs MSI-X... I think MSI vs MSI-X is just how it's configured, not the

Re: [Qemu-devel] [qemu-s390x] [RFC PATCH 1/3] hw/Kconfig: PCI bus implies PCI_DEVICES

2019-07-16 Thread Thomas Huth
On 16/07/2019 15.06, Markus Armbruster wrote: > Paolo Bonzini writes: > >> On 15/07/19 18:12, Cornelia Huck wrote: Is it INTx vs. MSI vs. MSI-X? >>> >>> I think for s390x we need (INTx || MSI) vs MSI-X... >> >> I think MSI vs MSI-X is just how it's configured, not the actual >> behavior, so

Re: [Qemu-devel] [qemu-s390x] [RFC PATCH 1/3] hw/Kconfig: PCI bus implies PCI_DEVICES

2019-07-16 Thread Markus Armbruster
Paolo Bonzini writes: > On 15/07/19 18:12, Cornelia Huck wrote: >>> Is it INTx vs. MSI vs. MSI-X? >> >> I think for s390x we need (INTx || MSI) vs MSI-X... > > I think MSI vs MSI-X is just how it's configured, not the actual > behavior, so it should be irrelevant. My best guesses from confusing

Re: [Qemu-devel] [qemu-s390x] [RFC PATCH 1/3] hw/Kconfig: PCI bus implies PCI_DEVICES

2019-07-15 Thread Paolo Bonzini
On 15/07/19 18:12, Cornelia Huck wrote: >> Is it INTx vs. MSI vs. MSI-X? > > I think for s390x we need (INTx || MSI) vs MSI-X... I think MSI vs MSI-X is just how it's configured, not the actual behavior, so it should be irrelevant. Paolo

Re: [Qemu-devel] [qemu-s390x] [RFC PATCH 1/3] hw/Kconfig: PCI bus implies PCI_DEVICES

2019-07-15 Thread Cornelia Huck
On Mon, 15 Jul 2019 18:08:45 +0200 Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > > > On 7/15/19 3:19 PM, Thomas Huth wrote: > >> On 15/07/2019 13.09, Cornelia Huck wrote: > >>> On Mon, 15 Jul 2019 13:04:28 +0200 > >>> Philippe Mathieu-Daudé wrote: > >>> > On 7/15/19 12

Re: [Qemu-devel] [qemu-s390x] [RFC PATCH 1/3] hw/Kconfig: PCI bus implies PCI_DEVICES

2019-07-15 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 7/15/19 3:19 PM, Thomas Huth wrote: >> On 15/07/2019 13.09, Cornelia Huck wrote: >>> On Mon, 15 Jul 2019 13:04:28 +0200 >>> Philippe Mathieu-Daudé wrote: >>> On 7/15/19 12:56 PM, Cornelia Huck wrote: > On Mon, 15 Jul 2019 12:48:55 +0200 > Thomas H

Re: [Qemu-devel] [qemu-s390x] [RFC PATCH 1/3] hw/Kconfig: PCI bus implies PCI_DEVICES

2019-07-15 Thread Thomas Huth
On 15/07/2019 15.38, Philippe Mathieu-Daudé wrote: > On 7/15/19 3:19 PM, Thomas Huth wrote: >> On 15/07/2019 13.09, Cornelia Huck wrote: >>> On Mon, 15 Jul 2019 13:04:28 +0200 >>> Philippe Mathieu-Daudé wrote: >>> On 7/15/19 12:56 PM, Cornelia Huck wrote: > On Mon, 15 Jul 2019 12:48:55 +0

Re: [Qemu-devel] [qemu-s390x] [RFC PATCH 1/3] hw/Kconfig: PCI bus implies PCI_DEVICES

2019-07-15 Thread Philippe Mathieu-Daudé
On 7/15/19 3:19 PM, Thomas Huth wrote: > On 15/07/2019 13.09, Cornelia Huck wrote: >> On Mon, 15 Jul 2019 13:04:28 +0200 >> Philippe Mathieu-Daudé wrote: >> >>> On 7/15/19 12:56 PM, Cornelia Huck wrote: On Mon, 15 Jul 2019 12:48:55 +0200 Thomas Huth wrote: > On 15/07/2019 12

Re: [Qemu-devel] [qemu-s390x] [RFC PATCH 1/3] hw/Kconfig: PCI bus implies PCI_DEVICES

2019-07-15 Thread Thomas Huth
On 15/07/2019 13.09, Cornelia Huck wrote: > On Mon, 15 Jul 2019 13:04:28 +0200 > Philippe Mathieu-Daudé wrote: > >> On 7/15/19 12:56 PM, Cornelia Huck wrote: >>> On Mon, 15 Jul 2019 12:48:55 +0200 >>> Thomas Huth wrote: >>> On 15/07/2019 12.19, Peter Maydell wrote: > On Mon, 15 Jul

Re: [Qemu-devel] [qemu-s390x] [RFC PATCH 1/3] hw/Kconfig: PCI bus implies PCI_DEVICES

2019-07-15 Thread Cornelia Huck
On Mon, 15 Jul 2019 13:04:28 +0200 Philippe Mathieu-Daudé wrote: > On 7/15/19 12:56 PM, Cornelia Huck wrote: > > On Mon, 15 Jul 2019 12:48:55 +0200 > > Thomas Huth wrote: > > > >> On 15/07/2019 12.19, Peter Maydell wrote: > >>> On Mon, 15 Jul 2019 at 11:15, Thomas Huth wrote: > >

Re: [Qemu-devel] [qemu-s390x] [RFC PATCH 1/3] hw/Kconfig: PCI bus implies PCI_DEVICES

2019-07-15 Thread Philippe Mathieu-Daudé
On 7/15/19 12:56 PM, Cornelia Huck wrote: > On Mon, 15 Jul 2019 12:48:55 +0200 > Thomas Huth wrote: > >> On 15/07/2019 12.19, Peter Maydell wrote: >>> On Mon, 15 Jul 2019 at 11:15, Thomas Huth wrote: On 15/07/2019 11.55, Philippe Mathieu-Daudé wrote: > If a controller device pr

Re: [Qemu-devel] [qemu-s390x] [RFC PATCH 1/3] hw/Kconfig: PCI bus implies PCI_DEVICES

2019-07-15 Thread Cornelia Huck
On Mon, 15 Jul 2019 12:48:55 +0200 Thomas Huth wrote: > On 15/07/2019 12.19, Peter Maydell wrote: > > On Mon, 15 Jul 2019 at 11:15, Thomas Huth wrote: > >> > >> On 15/07/2019 11.55, Philippe Mathieu-Daudé wrote: > >>> If a controller device provides a PCI bus, we can plug any PCI > >>> daugh