Re: [Qemu-devel] [qemu-s390x] virtio-ccw.c vs larger VIRTIO_QUEUE_MAX (coverity warning CID 1390619)

2018-05-15 Thread Cornelia Huck
On Tue, 15 May 2018 17:30:23 +0200 Halil Pasic wrote: > On 05/15/2018 04:01 PM, Cornelia Huck wrote: > > On Tue, 15 May 2018 15:17:51 +0200 > > Halil Pasic wrote: > > > > > >> 8< > >> From: Halil Pasic > >> Date

Re: [Qemu-devel] [qemu-s390x] virtio-ccw.c vs larger VIRTIO_QUEUE_MAX (coverity warning CID 1390619)

2018-05-15 Thread Halil Pasic
On 05/15/2018 04:01 PM, Cornelia Huck wrote: On Tue, 15 May 2018 15:17:51 +0200 Halil Pasic wrote: 8< From: Halil Pasic Date: Tue, 15 May 2018 13:57:44 +0200 Subject: [PATCH] WIP: cleanup virtio notify Signed-

Re: [Qemu-devel] [qemu-s390x] virtio-ccw.c vs larger VIRTIO_QUEUE_MAX (coverity warning CID 1390619)

2018-05-15 Thread Cornelia Huck
On Tue, 15 May 2018 15:17:51 +0200 Halil Pasic wrote: > 8< > From: Halil Pasic > Date: Tue, 15 May 2018 13:57:44 +0200 > Subject: [PATCH] WIP: cleanup virtio notify > > Signed-off-by: Halil Pasic > --- > hw/s390

Re: [Qemu-devel] [qemu-s390x] virtio-ccw.c vs larger VIRTIO_QUEUE_MAX (coverity warning CID 1390619)

2018-05-15 Thread Cornelia Huck
On Tue, 15 May 2018 14:00:30 +0200 Halil Pasic wrote: > On 05/15/2018 10:32 AM, Cornelia Huck wrote: > > On Mon, 14 May 2018 19:12:27 +0100 > > Peter Maydell wrote: > >> (Other odd code in that function: > >> vector = 0; > >> [...] > >> indicators |= 1ULL << vector; > >> is that

Re: [Qemu-devel] [qemu-s390x] virtio-ccw.c vs larger VIRTIO_QUEUE_MAX (coverity warning CID 1390619)

2018-05-15 Thread Halil Pasic
On 05/15/2018 02:07 PM, Peter Maydell wrote: On 15 May 2018 at 13:00, Halil Pasic wrote: To sum it up, my take on the whole is the diff below. I can convert it to a proper patch if we agree that's the way to go. From: Halil Pasic Date: Tue, 15 May 2018 13:57:44 +0200 Subject: [PATCH] WIP: c

Re: [Qemu-devel] [qemu-s390x] virtio-ccw.c vs larger VIRTIO_QUEUE_MAX (coverity warning CID 1390619)

2018-05-15 Thread Peter Maydell
On 15 May 2018 at 13:00, Halil Pasic wrote: > To sum it up, my take on the whole is the diff below. I can convert > it to a proper patch if we agree that's the way to go. > > From: Halil Pasic > Date: Tue, 15 May 2018 13:57:44 +0200 > Subject: [PATCH] WIP: cleanup virtio notify > > Signed-off-by:

Re: [Qemu-devel] [qemu-s390x] virtio-ccw.c vs larger VIRTIO_QUEUE_MAX (coverity warning CID 1390619)

2018-05-15 Thread Halil Pasic
On 05/15/2018 10:32 AM, Cornelia Huck wrote: On Mon, 14 May 2018 19:12:27 +0100 Peter Maydell wrote: Hi; Coverity has I think enabled a new warning recently, which is triggering on virtio_ccw_notify() in hw/s390x/virtio-ccw.c (CID 1390619). This function does indicators |= 1ULL << vect