Re: [Qemu-devel] [qemu PATCH for 2.10] i386: acpi: provide an XSDT instead of an RSDT

2017-07-28 Thread Kevin O'Connor
On Fri, Jul 28, 2017 at 04:20:10PM +0200, Laszlo Ersek wrote: > On 07/27/17 22:40, Kevin O'Connor wrote: > > On Wed, Jul 26, 2017 at 11:31:36AM +0200, Paolo Bonzini wrote: > >> The tables that QEMU provides are not ACPI 1.0 compatible since commit > >> 77af8a2b95 ("hw/i386: Use Rev3 FADT (ACPI

Re: [Qemu-devel] [qemu PATCH for 2.10] i386: acpi: provide an XSDT instead of an RSDT

2017-07-28 Thread Laszlo Ersek
On 07/27/17 22:40, Kevin O'Connor wrote: > On Wed, Jul 26, 2017 at 11:31:36AM +0200, Paolo Bonzini wrote: >> The tables that QEMU provides are not ACPI 1.0 compatible since commit >> 77af8a2b95 ("hw/i386: Use Rev3 FADT (ACPI 2.0) instead of Rev1 to improve >> guest OS support.", 2017-05-03). This

Re: [Qemu-devel] [qemu PATCH for 2.10] i386: acpi: provide an XSDT instead of an RSDT

2017-07-27 Thread Kevin O'Connor
On Wed, Jul 26, 2017 at 11:31:36AM +0200, Paolo Bonzini wrote: > The tables that QEMU provides are not ACPI 1.0 compatible since commit > 77af8a2b95 ("hw/i386: Use Rev3 FADT (ACPI 2.0) instead of Rev1 to improve > guest OS support.", 2017-05-03). This is visible with Windows 2000, > which refuses

Re: [Qemu-devel] [qemu PATCH for 2.10] i386: acpi: provide an XSDT instead of an RSDT

2017-07-26 Thread Michael S. Tsirkin
On Wed, Jul 26, 2017 at 04:24:41PM -0400, Paolo Bonzini wrote: > > > The point is that for PC we really should not keep piling up hacks, > > compatibility is more important. > > Non-explosion of the test matrix is just as important. Absolutely. > > > Doing it for PC only would mean switching >

Re: [Qemu-devel] [qemu PATCH for 2.10] i386: acpi: provide an XSDT instead of an RSDT

2017-07-26 Thread Paolo Bonzini
> The point is that for PC we really should not keep piling up hacks, > compatibility is more important. Non-explosion of the test matrix is just as important. > > Doing it for PC only would mean switching > > back from FADT rev3 to rev1, which is worse for guest OS support, > > It's only OSX

Re: [Qemu-devel] [qemu PATCH for 2.10] i386: acpi: provide an XSDT instead of an RSDT

2017-07-26 Thread Michael S. Tsirkin
On Wed, Jul 26, 2017 at 03:01:25PM +0200, Paolo Bonzini wrote: > On 26/07/2017 14:52, Michael S. Tsirkin wrote: > > On Wed, Jul 26, 2017 at 11:31:36AM +0200, Paolo Bonzini wrote: > >> The tables that QEMU provides are not ACPI 1.0 compatible since commit > >> 77af8a2b95 ("hw/i386: Use Rev3 FADT

Re: [Qemu-devel] [qemu PATCH for 2.10] i386: acpi: provide an XSDT instead of an RSDT

2017-07-26 Thread Michael S. Tsirkin
On Wed, Jul 26, 2017 at 02:07:13PM +0100, Daniel P. Berrange wrote: > On Wed, Jul 26, 2017 at 03:52:43PM +0300, Michael S. Tsirkin wrote: > > On Wed, Jul 26, 2017 at 11:31:36AM +0200, Paolo Bonzini wrote: > > > The tables that QEMU provides are not ACPI 1.0 compatible since commit > > > 77af8a2b95

Re: [Qemu-devel] [qemu PATCH for 2.10] i386: acpi: provide an XSDT instead of an RSDT

2017-07-26 Thread Daniel P. Berrange
On Wed, Jul 26, 2017 at 03:52:43PM +0300, Michael S. Tsirkin wrote: > On Wed, Jul 26, 2017 at 11:31:36AM +0200, Paolo Bonzini wrote: > > The tables that QEMU provides are not ACPI 1.0 compatible since commit > > 77af8a2b95 ("hw/i386: Use Rev3 FADT (ACPI 2.0) instead of Rev1 to improve > > guest OS

Re: [Qemu-devel] [qemu PATCH for 2.10] i386: acpi: provide an XSDT instead of an RSDT

2017-07-26 Thread Paolo Bonzini
On 26/07/2017 14:52, Michael S. Tsirkin wrote: > On Wed, Jul 26, 2017 at 11:31:36AM +0200, Paolo Bonzini wrote: >> The tables that QEMU provides are not ACPI 1.0 compatible since commit >> 77af8a2b95 ("hw/i386: Use Rev3 FADT (ACPI 2.0) instead of Rev1 to improve >> guest OS support.", 2017-05-03).

Re: [Qemu-devel] [qemu PATCH for 2.10] i386: acpi: provide an XSDT instead of an RSDT

2017-07-26 Thread Michael S. Tsirkin
On Wed, Jul 26, 2017 at 11:31:36AM +0200, Paolo Bonzini wrote: > The tables that QEMU provides are not ACPI 1.0 compatible since commit > 77af8a2b95 ("hw/i386: Use Rev3 FADT (ACPI 2.0) instead of Rev1 to improve > guest OS support.", 2017-05-03). This is visible with Windows 2000, > which refuses

[Qemu-devel] [qemu PATCH for 2.10] i386: acpi: provide an XSDT instead of an RSDT

2017-07-26 Thread Paolo Bonzini
The tables that QEMU provides are not ACPI 1.0 compatible since commit 77af8a2b95 ("hw/i386: Use Rev3 FADT (ACPI 2.0) instead of Rev1 to improve guest OS support.", 2017-05-03). This is visible with Windows 2000, which refuses to parse the rev3 FADT and fails to boot. The recommended solution in