Re: [Qemu-devel] [qemu devel] disable shared memory is not available with this QEMU binary

2015-04-01 Thread Marcel Apfelbaum
On 04/01/2015 07:20 PM, Eric Blake wrote: On 04/01/2015 10:11 AM, Marcel Apfelbaum wrote: On 04/01/2015 06:53 PM, Markus Armbruster wrote: Marcel Apfelbaum writes: [...] I noticed something weird. I cannot actually create an instance of machine or get a reference to current_machine in order

Re: [Qemu-devel] [qemu devel] disable shared memory is not available with this QEMU binary

2015-04-01 Thread Eric Blake
On 04/01/2015 10:11 AM, Marcel Apfelbaum wrote: > On 04/01/2015 06:53 PM, Markus Armbruster wrote: >> Marcel Apfelbaum writes: > [...] >>> I noticed something weird. I cannot actually create an instance of >>> machine >>> or get a reference to current_machine in order to query its properties! >>>

Re: [Qemu-devel] [qemu devel] disable shared memory is not available with this QEMU binary

2015-04-01 Thread Marcel Apfelbaum
On 04/01/2015 06:53 PM, Markus Armbruster wrote: Marcel Apfelbaum writes: [...] I noticed something weird. I cannot actually create an instance of machine or get a reference to current_machine in order to query its properties! It seems that util/qemu-config is used by qemu-img which obviously

Re: [Qemu-devel] [qemu devel] disable shared memory is not available with this QEMU binary

2015-04-01 Thread Markus Armbruster
Marcel Apfelbaum writes: > On 04/01/2015 11:28 AM, Markus Armbruster wrote: >> Marcel Apfelbaum writes: >> >>> On 03/31/2015 05:21 PM, Tony Krowiak wrote: Commit 49d2e648e8087d154d8bf8b91f27c8e05e79d5a6 removed the QemuOptDesc elements from the *desc* field of the *qemu_machine_o

Re: [Qemu-devel] [qemu devel] disable shared memory is not available with this QEMU binary

2015-04-01 Thread Marcel Apfelbaum
On 04/01/2015 11:28 AM, Markus Armbruster wrote: Marcel Apfelbaum writes: On 03/31/2015 05:21 PM, Tony Krowiak wrote: Commit 49d2e648e8087d154d8bf8b91f27c8e05e79d5a6 removed the QemuOptDesc elements from the *desc* field of the *qemu_machine_opts *array defined in vl.c. Since applying that

Re: [Qemu-devel] [qemu devel] disable shared memory is not available with this QEMU binary

2015-04-01 Thread Marcel Apfelbaum
On 04/01/2015 12:23 PM, Paolo Bonzini wrote: On 01/04/2015 11:14, Marcel Apfelbaum wrote: This + 'monkey-patch' may be a feasible solution for 2.4 Why monkey-patch and not just revert? There are already several machine sub-types that have their own options, some of the code I think it was a

Re: [Qemu-devel] [qemu devel] disable shared memory is not available with this QEMU binary

2015-04-01 Thread Paolo Bonzini
On 01/04/2015 11:14, Marcel Apfelbaum wrote: > This + 'monkey-patch' may be a feasible solution for 2.4 Why monkey-patch and not just revert? Paolo

Re: [Qemu-devel] [qemu devel] disable shared memory is not available with this QEMU binary

2015-04-01 Thread Marcel Apfelbaum
On 04/01/2015 12:07 PM, Paolo Bonzini wrote: On 01/04/2015 10:42, Markus Armbruster wrote: The obvious way to return them is to put them right back in qemu_machine_opts.desc[]. But then -machine rejects machine-specific parameters. Hack: monkey-patch them in after we're done parsing. Cleane

Re: [Qemu-devel] [qemu devel] disable shared memory is not available with this QEMU binary

2015-04-01 Thread Paolo Bonzini
On 01/04/2015 10:42, Markus Armbruster wrote: > The obvious way to return them is to put them right back in > qemu_machine_opts.desc[]. But then -machine rejects machine-specific > parameters. > > Hack: monkey-patch them in after we're done parsing. > > Cleaner: "empty desc[] means accept anyt

Re: [Qemu-devel] [qemu devel] disable shared memory is not available with this QEMU binary

2015-04-01 Thread Markus Armbruster
Paolo Bonzini writes: > On 01/04/2015 08:54, Marcel Apfelbaum wrote: >> This is the first object for which QemuOps are defined per >> sub-type and are not global (if you don't take "object" under >> consideration). > > We can return the same QemuOpts that were included before. > Per-machine-type

Re: [Qemu-devel] [qemu devel] disable shared memory is not available with this QEMU binary

2015-04-01 Thread Markus Armbruster
Marcel Apfelbaum writes: > On 03/31/2015 05:21 PM, Tony Krowiak wrote: >> Commit 49d2e648e8087d154d8bf8b91f27c8e05e79d5a6 removed the QemuOptDesc >> elements from the >> *desc* field of the *qemu_machine_opts *array defined in vl.c. Since >> applying that patch to qemu >> on my system, I can n

Re: [Qemu-devel] [qemu devel] disable shared memory is not available with this QEMU binary

2015-04-01 Thread Paolo Bonzini
On 01/04/2015 10:06, Marcel Apfelbaum wrote: >> >> We can return the same QemuOpts that were included before. >> Per-machine-type options are new and need not be covered by >> query-command-line-options. > > OK, we have them under hw/core/machine.c as "base" machine properties. > We still need a

Re: [Qemu-devel] [qemu devel] disable shared memory is not available with this QEMU binary

2015-04-01 Thread Marcel Apfelbaum
On 04/01/2015 11:01 AM, Paolo Bonzini wrote: On 01/04/2015 08:54, Marcel Apfelbaum wrote: This is the first object for which QemuOps are defined per sub-type and are not global (if you don't take "object" under consideration). We can return the same QemuOpts that were included before. Per-ma

Re: [Qemu-devel] [qemu devel] disable shared memory is not available with this QEMU binary

2015-04-01 Thread Paolo Bonzini
On 01/04/2015 08:54, Marcel Apfelbaum wrote: > This is the first object for which QemuOps are defined per > sub-type and are not global (if you don't take "object" under > consideration). We can return the same QemuOpts that were included before. Per-machine-type options are new and need not be

Re: [Qemu-devel] [qemu devel] disable shared memory is not available with this QEMU binary

2015-03-31 Thread Marcel Apfelbaum
On 03/31/2015 05:21 PM, Tony Krowiak wrote: Commit 49d2e648e8087d154d8bf8b91f27c8e05e79d5a6 removed the QemuOptDesc elements from the *desc* field of the *qemu_machine_opts *array defined in vl.c. Since applying that patch to qemu on my system, I can not start a guest from libvirt when certain

[Qemu-devel] [qemu devel] disable shared memory is not available with this QEMU binary

2015-03-31 Thread Tony Krowiak
Commit 49d2e648e8087d154d8bf8b91f27c8e05e79d5a6 removed the QemuOptDesc elements from the *desc* field of the *qemu_machine_opts *array defined in vl.c. Since applying that patch to qemu on my system, I can not start a guest from libvirt when certain machine options are configured for the guest