Re: [Qemu-devel] [question] savevm/delvm: Is it necessary to perform bdrv_drain_all before savevm and delvm?

2014-10-21 Thread Kevin Wolf
Am 21.10.2014 um 03:13 hat Zhang Haoyu geschrieben: > >> >> Hi, > >> >> > >> >> I noticed that bdrv_drain_all is performed in load_vmstate before > >> bdrv_snapshot_goto, > >> >> and bdrv_drain_all is performed in qmp_transaction before > >> internal_snapshot_prepare, > >> >> so is it also neccesar

Re: [Qemu-devel] [question] savevm/delvm: Is it necessary to perform bdrv_drain_all before savevm and delvm?

2014-10-20 Thread Zhang Haoyu
>> >> Hi, >> >> >> >> I noticed that bdrv_drain_all is performed in load_vmstate before >> bdrv_snapshot_goto, >> >> and bdrv_drain_all is performed in qmp_transaction before >> internal_snapshot_prepare, >> >> so is it also neccesary to perform bdrv_drain_all in savevm and delvm? >> > >> >Definite

Re: [Qemu-devel] [question] savevm/delvm: Is it necessary to perform bdrv_drain_all before savevm and delvm?

2014-10-20 Thread Kevin Wolf
Am 20.10.2014 um 17:09 hat Zhang Haoyu geschrieben: > >> Hi, > >> > >> I noticed that bdrv_drain_all is performed in load_vmstate before > bdrv_snapshot_goto, > >> and bdrv_drain_all is performed in qmp_transaction before > internal_snapshot_prepare, > >> so is it also neccesary to perform bdrv_dra

Re: [Qemu-devel] [question] savevm/delvm: Is it necessary to perform bdrv_drain_all before savevm and delvm?

2014-10-20 Thread Zhang Haoyu
>> Hi, >> >> I noticed that bdrv_drain_all is performed in load_vmstate before bdrv_snapshot_goto, >> and bdrv_drain_all is performed in qmp_transaction before internal_snapshot_prepare, >> so is it also neccesary to perform bdrv_drain_all in savevm and delvm? > >Definitely yes for savevm. do_s