Re: [Qemu-devel] [snabb-devel] Re: [PATCH v10 15/18] Add the vhost-user netdev backend to the command line

2014-06-09 Thread Eric Blake
On 06/09/2014 03:19 PM, Nikolay Nikolaev wrote: >>> +static CharDriverState *net_vhost_parse_chardev( >>> +const NetdevVhostUserOptions *opts) >> >> Unusual indentation, but I see your dilemma of fitting 80 columns. >> > What woudl be the right approach here, is leaving it 84 colums accept

Re: [Qemu-devel] [snabb-devel] Re: [PATCH v10 15/18] Add the vhost-user netdev backend to the command line

2014-06-09 Thread Nikolay Nikolaev
On Thu, Jun 5, 2014 at 7:08 PM, Eric Blake wrote: > On 05/27/2014 06:06 AM, Nikolay Nikolaev wrote: > > The supplied chardev id will be inspected for supported options. Only > > a socket backend, with a set path (i.e. a Unix socket) and optionally > > the server parameter set, will be allowed. Ot

Re: [Qemu-devel] [snabb-devel] Re: [PATCH v10 15/18] Add the vhost-user netdev backend to the command line

2014-06-09 Thread Nikolay Nikolaev
On Mon, Jun 9, 2014 at 4:31 PM, Michael S. Tsirkin wrote: > On Mon, Jun 09, 2014 at 04:28:23PM +0300, Nikolay Nikolaev wrote: > > Hello, > > > > > > On Thu, Jun 5, 2014 at 5:37 PM, Luiz Capitulino > wrote: > > > > On Tue, 27 May 2014 15:06:43 +0300 > > Nikolay Nikolaev wrote: > > > >

Re: [Qemu-devel] [snabb-devel] Re: [PATCH v10 15/18] Add the vhost-user netdev backend to the command line

2014-06-09 Thread Michael S. Tsirkin
On Mon, Jun 09, 2014 at 04:28:23PM +0300, Nikolay Nikolaev wrote: > Hello, > > > On Thu, Jun 5, 2014 at 5:37 PM, Luiz Capitulino > wrote: > > On Tue, 27 May 2014 15:06:43 +0300 > Nikolay Nikolaev wrote: > > > The supplied chardev id will be inspected for supported options. Only >

Re: [Qemu-devel] [snabb-devel] Re: [PATCH v10 15/18] Add the vhost-user netdev backend to the command line

2014-06-09 Thread Nikolay Nikolaev
Hello, On Thu, Jun 5, 2014 at 5:37 PM, Luiz Capitulino wrote: > On Tue, 27 May 2014 15:06:43 +0300 > Nikolay Nikolaev wrote: > > > The supplied chardev id will be inspected for supported options. Only > > a socket backend, with a set path (i.e. a Unix socket) and optionally > > the server para