Re: [Qemu-devel] [svt-core] [PATCH] kvmclock: update system_time_msr address forcibly

2017-05-25 Thread Paolo Bonzini
On 25/05/2017 11:40, Roman Kagan wrote: +kvmclock_struct_pa = env->system_time_msr & ~1ULL; + if (!(env->system_time_msr & 1ULL)) { /* KVM clock not active */ return 0; >>> Roman. >> Can't you avoid that call to each CPU? (ie fix the synchroniza

Re: [Qemu-devel] [svt-core] [PATCH] kvmclock: update system_time_msr address forcibly

2017-05-25 Thread Roman Kagan
On Wed, May 24, 2017 at 02:20:05PM -0300, Marcelo Tosatti wrote: > On Wed, May 24, 2017 at 06:54:09PM +0300, Roman Kagan wrote: > > On Wed, May 24, 2017 at 05:07:24PM +0300, Denis Plotnikov wrote: > > > Do an update of system_time_msr address every time before reading > > > the value of tsc_timesta

Re: [Qemu-devel] [svt-core] [PATCH] kvmclock: update system_time_msr address forcibly

2017-05-24 Thread Marcelo Tosatti
On Wed, May 24, 2017 at 06:54:09PM +0300, Roman Kagan wrote: > On Wed, May 24, 2017 at 05:07:24PM +0300, Denis Plotnikov wrote: > > Do an update of system_time_msr address every time before reading > > the value of tsc_timestamp from guest's kvmclock page. > > > > It should be done in a forcible m

Re: [Qemu-devel] [svt-core] [PATCH] kvmclock: update system_time_msr address forcibly

2017-05-24 Thread Roman Kagan
On Wed, May 24, 2017 at 05:07:24PM +0300, Denis Plotnikov wrote: > Do an update of system_time_msr address every time before reading > the value of tsc_timestamp from guest's kvmclock page. > > It should be done in a forcible manner because there is a situation > when system_time_msr has been set