Re: [Qemu-devel] [trivial for-2.6] util/id: fully allocate names table

2015-11-25 Thread John Snow
On 11/25/2015 03:18 AM, Markus Armbruster wrote: > John Snow writes: > >> Trivial: this array should be allocated to have ID_MAX entries always. >> Otherwise if someone were to forget to expand this table, the assertion >> in the id generator won't actually trigger; it will read junk data. > >

Re: [Qemu-devel] [trivial for-2.6] util/id: fully allocate names table

2015-11-25 Thread Markus Armbruster
Kevin Wolf writes: > Am 25.11.2015 um 09:18 hat Markus Armbruster geschrieben: >> John Snow writes: >> >> > Trivial: this array should be allocated to have ID_MAX entries always. >> > Otherwise if someone were to forget to expand this table, the assertion >> > in the id generator won't actually

Re: [Qemu-devel] [trivial for-2.6] util/id: fully allocate names table

2015-11-25 Thread Kevin Wolf
Am 25.11.2015 um 09:18 hat Markus Armbruster geschrieben: > John Snow writes: > > > Trivial: this array should be allocated to have ID_MAX entries always. > > Otherwise if someone were to forget to expand this table, the assertion > > in the id generator won't actually trigger; it will read junk

Re: [Qemu-devel] [trivial for-2.6] util/id: fully allocate names table

2015-11-25 Thread Markus Armbruster
John Snow writes: > Trivial: this array should be allocated to have ID_MAX entries always. > Otherwise if someone were to forget to expand this table, the assertion > in the id generator won't actually trigger; it will read junk data. You mean this one: assert(id < ID_MAX); The assertion i

[Qemu-devel] [trivial for-2.6] util/id: fully allocate names table

2015-11-24 Thread John Snow
Trivial: this array should be allocated to have ID_MAX entries always. Otherwise if someone were to forget to expand this table, the assertion in the id generator won't actually trigger; it will read junk data. Signed-off-by: John Snow --- util/id.c | 2 +- 1 file changed, 1 insertion(+), 1 dele