Re: [Qemu-devel] [v3][PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-04-01 Thread Ian Campbell
On Wed, 2015-04-01 at 17:18 +0800, Chen, Tiejun wrote: > Currently Qemu maintainers are busy finalizing qemu 2.3, they don't > complete to review all associated qemu patch set. Although that don't > bring any change to our two patches on Xen side, I think we'd better > merge these patches until

Re: [Qemu-devel] [v3][PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-04-01 Thread Chen, Tiejun
Perhaps add "With qemu-xen-traditional IGD is always assumed and other options than autodetect or explicit IGD will result in an error"? Will do. diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c index a8b08f2..4fd6310 100644 --- a/tools/libxl/libxl_dm.c +++ b/tools/libxl/libxl_dm

Re: [Qemu-devel] [v3][PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-04-01 Thread Ian Campbell
On Wed, 2015-04-01 at 09:05 +0800, Chen, Tiejun wrote: > @@ -699,9 +699,35 @@ working graphics passthrough. See the > XenVGAPassthroughTestedAdapters > L wiki page > for currently supported graphics cards for gfx_passthru. > > -gfx_pas

Re: [Qemu-devel] [v3][PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-31 Thread Chen, Tiejun
On 2015/3/30 17:19, Ian Campbell wrote: On Mon, 2015-03-30 at 09:28 +0800, Chen, Tiejun wrote: Sounds it should be a legacy fix to qemu-xen-tranditional :) So lets do it now, @@ -326,6 +326,10 @@ static char ** libxl__build_device_model_args_old(libxl__gc *gc, } if (libxl_

Re: [Qemu-devel] [v3][PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-30 Thread Ian Campbell
On Mon, 2015-03-30 at 09:28 +0800, Chen, Tiejun wrote: > Sounds it should be a legacy fix to qemu-xen-tranditional :) So lets do > it now, > > @@ -326,6 +326,10 @@ static char ** > libxl__build_device_model_args_old(libxl__gc *gc, > } > if (libxl_defbool_val(b_info->u.hvm.gfx

Re: [Qemu-devel] [v3][PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-29 Thread Chen, Tiejun
On 2015/3/27 17:54, Ian Campbell wrote: On Fri, 2015-03-27 at 09:29 +0800, Chen, Tiejun wrote: On 2015/3/26 18:06, Ian Campbell wrote: On Thu, 2015-03-26 at 08:53 +0800, Chen, Tiejun wrote: Hrm, OK. I suppose we can live with autodetect and igd both meaning igd and whoever adds a new type will

Re: [Qemu-devel] [v3][PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-27 Thread Ian Campbell
On Fri, 2015-03-27 at 09:29 +0800, Chen, Tiejun wrote: > On 2015/3/26 18:06, Ian Campbell wrote: > > On Thu, 2015-03-26 at 08:53 +0800, Chen, Tiejun wrote: > >>> Hrm, OK. I suppose we can live with autodetect and igd both meaning igd > >>> and whoever adds a new type will have to remember to add a

Re: [Qemu-devel] [v3][PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-26 Thread Chen, Tiejun
On 2015/3/26 18:06, Ian Campbell wrote: On Thu, 2015-03-26 at 08:53 +0800, Chen, Tiejun wrote: Hrm, OK. I suppose we can live with autodetect and igd both meaning igd and whoever adds a new type will have to remember to add a check for qemu-trad then. When we really have to introduce a new ty

Re: [Qemu-devel] [v3][PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-26 Thread Ian Campbell
On Thu, 2015-03-26 at 08:53 +0800, Chen, Tiejun wrote: > > Hrm, OK. I suppose we can live with autodetect and igd both meaning igd > > and whoever adds a new type will have to remember to add a check for > > qemu-trad then. > > > > When we really have to introduce a new type, this means we probabl

Re: [Qemu-devel] [v3][PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-25 Thread Chen, Tiejun
On 2015/3/25 18:32, Ian Campbell wrote: On Wed, 2015-03-25 at 09:10 +0800, Chen, Tiejun wrote: +But when given as a string the B option describes the type +of device to enable. Not this behavior is only supported with upstream "Note" and "the upstream..." Fixed. +=item "igd" + +Enables

Re: [Qemu-devel] [v3][PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-25 Thread Ian Campbell
On Wed, 2015-03-25 at 09:10 +0800, Chen, Tiejun wrote: > +But when given as a string the B option describes the type > +of device to enable. Not this behavior is only supported with upstream "Note" and "the upstream..." > +=item "igd" > + > +Enables graphics device PCI passthrough but force set

Re: [Qemu-devel] [v3][PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-24 Thread Chen, Tiejun
On 2015/3/24 22:50, Ian Campbell wrote: On Mon, 2015-03-23 at 09:17 +0800, Tiejun Chen wrote: Although we already have 'gfx_passthru' in b_info, this doesn' suffice Fixed. ^t after we want to handle IGD specifically. Now we

Re: [Qemu-devel] [v3][PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-24 Thread Ian Campbell
On Mon, 2015-03-23 at 09:17 +0800, Tiejun Chen wrote: > Although we already have 'gfx_passthru' in b_info, this doesn' suffice ^t > after we want to handle IGD specifically. Now we define a new field of > type, gfx_passthru_kind, to

[Qemu-devel] [v3][PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-22 Thread Tiejun Chen
Although we already have 'gfx_passthru' in b_info, this doesn' suffice after we want to handle IGD specifically. Now we define a new field of type, gfx_passthru_kind, to indicate we're trying to pass IGD. Actually this means we can benefit this to support other specific devices just by extending gf