Re: [Qemu-devel] [v5][PATCH 3/5] xen, gfx passthrough: support Intel IGD passthrough with VT-D

2014-06-27 Thread Chen, Tiejun
On 2014/6/25 15:04, Michael S. Tsirkin wrote: On Wed, Jun 25, 2014 at 10:17:19AM +0800, Tiejun Chen wrote: Some registers of Intel IGD are mapped in host bridge, so it needs to [snip] static int is_vga_passthrough(XenHostPCIDevice *dev) { @@ -291,3 +292,158 @@ static int create_pseudo_pc

Re: [Qemu-devel] [v5][PATCH 3/5] xen, gfx passthrough: support Intel IGD passthrough with VT-D

2014-06-26 Thread Chen, Tiejun
On 2014/6/26 14:04, Michael S. Tsirkin wrote: On Thu, Jun 26, 2014 at 01:34:14PM +0800, Chen, Tiejun wrote: On 2014/6/25 22:05, Michael S. Tsirkin wrote: On Wed, Jun 25, 2014 at 10:17:19AM +0800, Tiejun Chen wrote: Some registers of Intel IGD are mapped in host bridge, so it needs to passthrou

Re: [Qemu-devel] [v5][PATCH 3/5] xen, gfx passthrough: support Intel IGD passthrough with VT-D

2014-06-25 Thread Michael S. Tsirkin
On Thu, Jun 26, 2014 at 01:34:14PM +0800, Chen, Tiejun wrote: > On 2014/6/25 22:05, Michael S. Tsirkin wrote: > >On Wed, Jun 25, 2014 at 10:17:19AM +0800, Tiejun Chen wrote: > >>Some registers of Intel IGD are mapped in host bridge, so it needs to > >>passthrough these registers of physical host br

Re: [Qemu-devel] [v5][PATCH 3/5] xen, gfx passthrough: support Intel IGD passthrough with VT-D

2014-06-25 Thread Chen, Tiejun
On 2014/6/25 22:05, Michael S. Tsirkin wrote: On Wed, Jun 25, 2014 at 10:17:19AM +0800, Tiejun Chen wrote: Some registers of Intel IGD are mapped in host bridge, so it needs to passthrough these registers of physical host bridge to guest because emulated host bridge in guest doesn't have these m

Re: [Qemu-devel] [v5][PATCH 3/5] xen, gfx passthrough: support Intel IGD passthrough with VT-D

2014-06-25 Thread Michael S. Tsirkin
On Wed, Jun 25, 2014 at 10:17:19AM +0800, Tiejun Chen wrote: > Some registers of Intel IGD are mapped in host bridge, so it needs to > passthrough these registers of physical host bridge to guest because > emulated host bridge in guest doesn't have these mappings. > > The original patch is from We

Re: [Qemu-devel] [v5][PATCH 3/5] xen, gfx passthrough: support Intel IGD passthrough with VT-D

2014-06-25 Thread Chen, Tiejun
On 2014/6/25 14:25, Paolo Bonzini wrote: Il 25/06/2014 04:17, Tiejun Chen ha scritto: +int pci_create_pch(PCIBus *bus) +{ +XenHostPCIDevice hdev; +int r = 0; + +if (!xen_has_gfx_passthru) { +return r; +} + You could make this an assertion, since the function is never ca

Re: [Qemu-devel] [v5][PATCH 3/5] xen, gfx passthrough: support Intel IGD passthrough with VT-D

2014-06-25 Thread Michael S. Tsirkin
On Wed, Jun 25, 2014 at 10:17:19AM +0800, Tiejun Chen wrote: > Some registers of Intel IGD are mapped in host bridge, so it needs to > passthrough these registers of physical host bridge to guest because > emulated host bridge in guest doesn't have these mappings. > > The original patch is from We

Re: [Qemu-devel] [v5][PATCH 3/5] xen, gfx passthrough: support Intel IGD passthrough with VT-D

2014-06-24 Thread Paolo Bonzini
Il 25/06/2014 04:17, Tiejun Chen ha scritto: +int pci_create_pch(PCIBus *bus) +{ +XenHostPCIDevice hdev; +int r = 0; + +if (!xen_has_gfx_passthru) { +return r; +} + You could make this an assertion, since the function is never called with xen_has_gfx_passthru == 0. Or

[Qemu-devel] [v5][PATCH 3/5] xen, gfx passthrough: support Intel IGD passthrough with VT-D

2014-06-24 Thread Tiejun Chen
Some registers of Intel IGD are mapped in host bridge, so it needs to passthrough these registers of physical host bridge to guest because emulated host bridge in guest doesn't have these mappings. The original patch is from Weidong Han Signed-off-by: Yang Zhang Signed-off-by: Tiejun Chen Cc: