Re: [Qemu-devel] [v5 12/12] migration: Add commands to set and query parameter

2015-03-19 Thread Li, Liang Z
> > >> The command takes a list of key-value pairs. Looks like this > > >> (example stolen from your patch to qmp-commands.hx): > > >> > > >> { "execute": "migrate-set-parameters", > > >> "arguments": { "parameters": > > >> [ { "parameter": "compress-level", "value":

Re: [Qemu-devel] [v5 12/12] migration: Add commands to set and query parameter

2015-03-19 Thread Eric Blake
On 03/18/2015 08:30 PM, Li, Liang Z wrote: >>> +'migrate-set-parameters', >>> + 'data': { 'parameters': ['MigrationParameterStatus'] } } >> >> The command takes a list of key-value pairs. Looks like this (example stolen >> from your patch to qmp-commands.hx): >> >> { "execute": "migrate-set-

Re: [Qemu-devel] [v5 12/12] migration: Add commands to set and query parameter

2015-03-19 Thread Li, Liang Z
> >> The command takes a list of key-value pairs. Looks like this > >> (example stolen from your patch to qmp-commands.hx): > >> > >> { "execute": "migrate-set-parameters", > >> "arguments": { "parameters": > >> [ { "parameter": "compress-level", "value": 1 } > >> ]

Re: [Qemu-devel] [v5 12/12] migration: Add commands to set and query parameter

2015-03-19 Thread Markus Armbruster
"Li, Liang Z" writes: >> > +# >> > +# Migration parameter information >> > +# >> > +# @compress-level: compression level >> > +# >> > +# @compress-threads: compression thread count # # >> > +@decompress-threads: decompression thread count # # Since: 2.3 ## { >> > +'union': 'MigrationParameterStat

Re: [Qemu-devel] [v5 12/12] migration: Add commands to set and query parameter

2015-03-18 Thread Li, Liang Z
> > +# > > +# Migration parameter information > > +# > > +# @compress-level: compression level > > +# > > +# @compress-threads: compression thread count # # > > +@decompress-threads: decompression thread count # # Since: 2.3 ## { > > +'union': 'MigrationParameterStatus', > > + 'base': 'MigrationPa

Re: [Qemu-devel] [v5 12/12] migration: Add commands to set and query parameter

2015-03-12 Thread Markus Armbruster
Copying Eric for additional QAPI design expertise. I'm going to review just the QAPI schema changes. Liang Li writes: > Add the qmp and hmp commands to tune and query the parameters used in > live migration. > > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang [...] > diff --git a/qapi-sch

Re: [Qemu-devel] [v5 12/12] migration: Add commands to set and query parameter

2015-03-11 Thread Dr. David Alan Gilbert
* Liang Li (liang.z...@intel.com) wrote: > Add the qmp and hmp commands to tune and query the parameters used in > live migration. > > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang Hi, You might like to split this patch into two; one with no actual parameters in the lists, and then a s

Re: [Qemu-devel] [v5 12/12] migration: Add commands to set and query parameter

2015-02-11 Thread Juan Quintela
Liang Li wrote: > Add the qmp and hmp commands to tune and query the parameters used in > live migration. > > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang I agree with the existence of this changes, and we could use them for existing paramenters like migration_speed (independent of this

[Qemu-devel] [v5 12/12] migration: Add commands to set and query parameter

2015-02-10 Thread Liang Li
Add the qmp and hmp commands to tune and query the parameters used in live migration. Signed-off-by: Liang Li Signed-off-by: Yang Zhang --- hmp-commands.hx | 17 hmp.c | 56 + hmp.h | 4 ++ include/m