+static void
+xen_igd_passthrough_isa_bridge_create(XenPCIPassthroughState *s,
+ XenHostPCIDevice *dev)
+{
I suggest this implementation, and the table, are moved
to the same file where igd-passthrough-isa-bridge
is implemented. The function can get PCIDevice
+
+if (pch_dev_id == 0x) {
+fprintf(stderr, "unsupported PCH!\n");
I would drop this fprintf: this likely means a newer
card, so the bridge is not necessary.
Okay.
+return;
+}
+
+/* Currently IGD drivers always need to access PCH by 1f.0. */
+pci_dev = p
On Mon, Jan 19, 2015 at 05:28:40PM +0800, Tiejun Chen wrote:
> Currently IGD drivers always need to access PCH by 1f.0. But we
> don't want to poke that directly to get ID, and although in real
> world different GPU should have different PCH. But actually the
> different PCH DIDs likely map to diff
On Mon, Jan 19, 2015 at 05:28:40PM +0800, Tiejun Chen wrote:
> Currently IGD drivers always need to access PCH by 1f.0. But we
> don't want to poke that directly to get ID, and although in real
> world different GPU should have different PCH. But actually the
> different PCH DIDs likely map to diff
On 2015/1/19 21:58, Michael S. Tsirkin wrote:
On Mon, Jan 19, 2015 at 12:57:18PM +0100, Gerd Hoffmann wrote:
On Mo, 2015-01-19 at 17:28 +0800, Tiejun Chen wrote:
Currently IGD drivers always need to access PCH by 1f.0. But we
Obvious question: q35?
q35 already has a isa bridge @ 0x1f.0. Gue
On Mon, Jan 19, 2015 at 12:57:18PM +0100, Gerd Hoffmann wrote:
> On Mo, 2015-01-19 at 17:28 +0800, Tiejun Chen wrote:
> > Currently IGD drivers always need to access PCH by 1f.0. But we
>
> Obvious question: q35?
>
> q35 already has a isa bridge @ 0x1f.0. Guess that needs to be extended
> for th
On Mo, 2015-01-19 at 17:28 +0800, Tiejun Chen wrote:
> Currently IGD drivers always need to access PCH by 1f.0. But we
Obvious question: q35?
q35 already has a isa bridge @ 0x1f.0. Guess that needs to be extended
for the pass-through then (simliar to the host bridge) instead of adding
a dummy br
Currently IGD drivers always need to access PCH by 1f.0. But we
don't want to poke that directly to get ID, and although in real
world different GPU should have different PCH. But actually the
different PCH DIDs likely map to different PCH SKUs. We do the
same thing for the GPU. For PCH, the differ
